Mp bug fix and tasks improvement #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvaiko
reviewed
Oct 9, 2023
scripts/ai/jobs/CpAIJob.lua
Outdated
| end | ||
| if hasFinished and vehicle:getCpSettings().foldImplementAtEnd:getValue() then | ||
| --- Folds implements at the end if the setting is active. | ||
| vehicle:prepareForAIDriving() |
There was a problem hiding this comment.
Wouldn't doing this rather belong to the strategy?
pvaiko
reviewed
Oct 10, 2023
| --- Event raised when the driver was stopped. | ||
| ---@param hasFinished boolean|nil flag passed by the info text | ||
| function AIDriveStrategyCourse:onFinished(hasFinished) | ||
| self:raiseControllerEvent(self.onFinishedEvent, hasFinished) |
There was a problem hiding this comment.
hasFinished is not used in any onFinished() controller function, or is this for the future only?
… description translations. - Info text message should now be cleared correctly on the server - The task desciptions on the ai map, while running where adjusted. - No every translation is yet used, but it gives a good roadmap on whats next with the tasks Test Multiplayer: - Start and stop of every driver - Checking if the info text messages are working correctly
schwiti6190
force-pushed
the
MP-Bug-fix-and-tasks-improvement
branch
from
267bc6d to
c1bae97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info: Not every task description is yet used but should be in the near future
Test Multiplayer: