[Experiment] Shimmer #379
[Experiment] Shimmer #379
Conversation
|
@Arlodotexe found out what happens if you try and run WASM head, it just says that the underlying project isn't compatible with the TFM... But since we don't build those the same way in the CI, it works fine here. So just something we can improve later for the |
michael-hawker
added
the
experiment 🧪
There was a problem hiding this comment.
Looks good, tested on UWP and WindowsAppSDK without issue (so cool to see UWP code just working over there via Labs).
Have some suggestions for the property names and future investigations we should track.
FYI @JustinXinLiu
| <Grid Width="80" | ||
| Height="20" | ||
| HorizontalAlignment="Center"> | ||
| <TextBlock x:Name="Title" | ||
| FontWeight="SemiBold" | ||
| Text="This is a title" | ||
| Visibility="{x:Bind HasLoaded, Mode=OneWay}" /> | ||
| <labs:Shimmer Visibility="{x:Bind local:ShimmerSample.ReverseVisibility(Title.Visibility), Mode=OneWay}" /> | ||
| </Grid> |
There was a problem hiding this comment.
This is pretty similar to how the Store uses it, eh? Though they have a faux-item template and swap it out later or something with a selector? (We should probably show another example of how that works for an items collection.)
We should create a tracking issue for listing out next steps. (close to defining how we want to track independent issues tied to an experiment)
It'd be really cool to investigate if we could make this easier to use, though I think that'll have to be an 8.1 thing, and this is basically just the raw component that knows how to fill a space and shimmer, eh?
|
|
||
|
|
There was a problem hiding this comment.
extra newline
| #endif | ||
|
|
||
|
|
||
| namespace CommunityToolkit.Labs.WinUI; |
There was a problem hiding this comment.
Should we try the new CommunityToolkit.WinUI.Controls namespace here yet?
| /// A generic shimmer control that can be used to construct a beautiful loading effect. | ||
| /// </summary> | ||
| [TemplatePart(Name = PART_Shape, Type = typeof(Rectangle))] | ||
| #pragma warning disable CA1001 // Types that own disposable fields should be disposable |
There was a problem hiding this comment.
Should be resolved once we fix #377 eh?
| private bool _initialized; | ||
| private bool _animationStarted; | ||
|
|
||
| #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable. |
There was a problem hiding this comment.
We should probably make everything probably nullable?
| <ControlTemplate TargetType="labs:Shimmer"> | ||
| <Border x:Name="Shape" | ||
| Background="{TemplateBinding Background}" | ||
| CornerRadius="{TemplateBinding CornerRadius}" /> | ||
| </ControlTemplate> |
There was a problem hiding this comment.
So little XAML. As another follow-up for the tracking issue, maybe should investigate if we can go the ContentPresenter route like we did with Constrained Box and do some funky stuff like that... Trying to think what the most lightweight element we can inherit from would be since Border is sealed... As we could take a couple of approaches, but would be nice to remove the XAML template as then would be super light-weight.
ContentPresenter would lend itself to just wrapping something else, though I know our attached shadow like effect route could be interesting as well. Probably different use cases depending on what and how things are being loaded. We'll definitely have to play around more with these ideas in the future.
Co-Authored-By: Justin Liu <[email protected]>
niels9001
force-pushed
the
user/niels9001/shimmer
branch
from
1e0ac28 to
1d29f9c
Compare
Co-Authored-By: Justin Liu <[email protected]>
…Toolkit/Labs-Windows into user/niels9001/shimmer
|
Closing this for: #391 |
Adding the Shimmer control from the Store. See: #381