Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Labs from the default namespace for new components #387

Closed
20 tasks
Arlodotexe opened this issue Mar 7, 2023 · 0 comments · Fixed by #394
Closed
20 tasks

Remove Labs from the default namespace for new components #387

Arlodotexe opened this issue Mar 7, 2023 · 0 comments · Fixed by #394
Assignees
Labels
bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments

Comments

@Arlodotexe
Copy link
Member

Arlodotexe commented Mar 7, 2023

Describe the bug

The default templated namespace for all components uses the Labs moniker, which won't work for the main toolkit.

After reviewing past discussions, @michael-hawker, @niels9001 and @Arlodotexe have settled on:

  • CommunityToolkit.Labs.WinUI.Controls.ComponentName for the package ID.
  • CommunityToolkit.WinUI.Controls.ComponentName for the default namespace.

Reasoning behind this:

Steps to reproduce

n/a

Expected behavior

n/a

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

@Arlodotexe Arlodotexe added bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments labels Mar 7, 2023
@Arlodotexe Arlodotexe added this to the Labs Submodule Prep milestone Mar 7, 2023
@Arlodotexe Arlodotexe self-assigned this Mar 7, 2023
@Arlodotexe Arlodotexe moved this to In Progress in Windows Community Toolkit Mar 7, 2023
@michael-hawker michael-hawker moved this to 🏗 In progress in Toolkit 8.x Mar 7, 2023
@Arlodotexe Arlodotexe moved this from 🏗 In progress to 👀 In review in Toolkit 8.x Mar 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Windows Community Toolkit Mar 10, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Toolkit 8.x Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant