This repository has been archived by the owner on Jan 14, 2024. It is now read-only.
generated from CodeYourFuture/CYF-Coursework-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 438
London 10-Danny Romero-JavaScript-Core-1-coursework-week2 #447
Open
Elenar9
wants to merge
7
commits into
CodeYourFuture:main
Choose a base branch
from
Elenar9:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
765c6a1
javaScript-core-1-Coursework-week2
Elenar9 c28ca4d
Update 1-fix-functions.js
Elenar9 ee7ee5e
javaScript-Core-1-Coursework-Week2
Elenar9 f34c802
javaScript-Core-1-Coursework-Week2
Elenar9 2b54619
javascript-core-1-coursework-week2
Elenar9 61d2487
Javascript-core-1-coursework-week2
Elenar9 aa4a6a4
Update 1-factorial.js
Elenar9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,13 @@ | |
1. the user should be 18 or older | ||
2. the user must be logged in | ||
*/ | ||
function isAcceptableUser(userAge, isLoggedIn) {} | ||
function isAcceptableUser(userAge, isLoggedIn) { | ||
if(userAge>= 18 && isLoggedIn){ | ||
return true | ||
}else{ | ||
return false | ||
} | ||
} | ||
|
||
/* | ||
Complete the function to apply discount percent based on how much is totalPrice in user cart. | ||
|
@@ -15,37 +21,93 @@ function isAcceptableUser(userAge, isLoggedIn) {} | |
is applieds and 142.5 should be returned) | ||
*/ | ||
|
||
function applyDiscount(totalPrice) {} | ||
function applyDiscount(totalPrice) { | ||
if (totalPrice>200){ | ||
return totalPrice-(totalPrice * 0.1) | ||
}else { | ||
return totalPrice-(totalPrice *0.05) | ||
} | ||
} | ||
|
||
/* | ||
Complete the function to print to the console the odd numbers between 1 and limit (use a while loop): | ||
*/ | ||
function printOddNumbers(limit) {} | ||
|
||
function printOddNumbers(limit) { | ||
let numberOfLoops= 1 | ||
while (numberOfLoops <limit) { | ||
console.log(numberOfLoops); | ||
numberOfLoops = numberOfLoops + 2; | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment: Mine: |
||
|
||
/* | ||
Complete the buyTwoGetTheCheapestFree function: if user buys two items, the cheapest item will be free! | ||
The function should return the price to be paid once the discount is applied. | ||
*/ | ||
function buyTwoGetTheCheapestFree(price1, price2) {} | ||
|
||
|
||
function buyTwoGetTheCheapestFree(price1, price2) { | ||
// let price1 = 700 | ||
// let price2 = 500 | ||
if(price1>price2) { | ||
return price1; | ||
}else if (price1 < price2) | ||
return price2; | ||
} | ||
|
||
|
||
|
||
/* | ||
Complete the function to determine if it is suitable for a person to register based on their age! | ||
- if the person is 12 or younger it should return "You Are Too Young To Register" | ||
- if the person is older than 12 and younger than 90 it should return "You Can Register" | ||
- if the person is 90 or older it should return "You Don't Need To Register" | ||
*/ | ||
function canRegister(age) {} | ||
function canRegister(age) { | ||
if(age<=12){ | ||
return "You Are Too Young To Register" | ||
} | ||
else if (age> 12 && age<90){ | ||
return "You Can Register" | ||
}else { | ||
return "You Don't Need To Register" | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment: A stylistic thing. Sometimes you have spaces between code blocks and sometimes not. Compare Line 68 (age<12){ |
||
|
||
/* | ||
Complete the function so that it prints out to the console numbers in reverse order starting at | ||
Complete the 1 (function so that it prints out to the console numbers in reverse order starting at | ||
number and going down to 1 (e.g. if number was 3, it would print: | ||
3 | ||
2 | ||
1 | ||
) | ||
*/ | ||
|
||
function countReverse(number) {} | ||
/*function countReverse(number) { | ||
number = number + ""; | ||
console.log() | ||
}*/ | ||
|
||
function countReverse(number) { | ||
for(let i=number; i>0; i--){ | ||
console.log(i) | ||
} | ||
} | ||
|
||
// | ||
// function repeatStr (n, s) { | ||
// var str=""; | ||
// for(var i=0; i < n; i++) | ||
// str+=s; | ||
// return str; | ||
// } | ||
/*console.log(reverseNum(1234567));*/ | ||
|
||
|
||
|
||
|
||
|
||
|
||
/* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment: Well done! You code is same as mine and should work.