This repository has been archived by the owner on Jan 14, 2024. It is now read-only.
London 10-Danny Romero-JavaScript-Core-1-coursework-week2 #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answer 2 mandatory
finished i-fix-Function
update exercise mandatory
update 2-function-creation
|
I finished the extra exercise |
softacoder
reviewed
Mar 3, 2023
|
|
||
| if (isBigEnough) { | ||
| if (isBigEnough > 10) { | ||
| return "num is greater than 10"; | ||
| } else { | ||
| return "num is not big enough"; |
There was a problem hiding this comment.
Comment: Well done! You code is same as mine and should work.
| console.log(numberOfLoops); | ||
| numberOfLoops = numberOfLoops + 2; | ||
| } | ||
| } |
There was a problem hiding this comment.
Comment:
You have labelled the values different than me but the function is the same. Well done!
Mine:
function printOddNumbers(limit) {
let num=1;
while(num<limit){
console.log(num);
num=num+2;
}
}
| }else { | ||
| return "You Don't Need To Register" | ||
| } | ||
| } |
There was a problem hiding this comment.
Comment: A stylistic thing. Sometimes you have spaces between code blocks and sometimes not. Compare Line 68 (age<12){
But on line 71 (age> 12 && age<90){
update exercise 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?