Move parameter constructor to a package extension, use name maps #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 93.02% 93.06% +0.03%
==========================================
Files 9 10 +1
Lines 1133 1139 +6
==========================================
+ Hits 1054 1060 +6
Misses 79 79 ☔ View full report in Codecov by Sentry. |
nefrathenrici
force-pushed
the
ne/param_extension
branch
from
920e575 to
27bc58e
Compare
glwagner
reviewed
Jan 16, 2024
nefrathenrici
force-pushed
the
ne/param_extension
branch
2 times, most recently
from
6581c21 to
1f3c5fb
Compare
nefrathenrici
force-pushed
the
ne/param_extension
branch
from
c7bc573 to
849fb59
Compare
charleskawczynski
approved these changes
Jan 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a package extension which includes new convenience constructors for
ThermodynamicsParameterswhen CLIMAParameters is loaded.The constructors are
ThermodynamicsParameters(FT)ThermodynamicsParameters(toml_dict)The core changes are in
ext/CreateParametersExt.jlandProject.toml, but I have updated the repo to work with the new parameter constructor.This PR updates to the newest release of ClimaParameters and incorporates breaking changes.
This PR remove all instances of the
parameter_setfunction and replaces it with the new constructors.I will also fix up the import statements if people like the core changes of this PR.