Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameter constructor to a package extension, use name maps #152

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Jan 16, 2024

This PR adds a package extension which includes new convenience constructors for SurfaceFluxesParameters and the various UniversalFunctions parameter structs when CLIMAParameters is loaded.

The core changes are in ext/CreateParametersExt.jl and Project.toml, but I have updated all of the tests and docs to work with the new constructors.

This PR also alters recover_profile to not require a UniversalFunctionType as an argument, since it can be obtained from UniversalFunctionParams within the function. With a followup PR I would like to remove the UniversalFunctionTypes (BusingerType, ChengType, etc).

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (39ea36b) 89.49% compared to head (d08fccb) 90.05%.
Report is 1 commits behind head on main.

❗ Current head d08fccb differs from pull request most recent head 378af12. Consider uploading reports for the commit 378af12 to get more accurate results

Files Patch % Lines
src/SurfaceFluxes.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   89.49%   90.05%   +0.56%     
==========================================
  Files           3        4       +1     
  Lines         790      835      +45     
==========================================
+ Hits          707      752      +45     
  Misses         83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nefrathenrici nefrathenrici marked this pull request as ready for review January 18, 2024 20:57
@akshaysridhar akshaysridhar added parameters enhancement New feature or request labels Jan 19, 2024
@nefrathenrici nefrathenrici merged commit 90343fb into main Jan 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parameters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants