Move parameter constructor to a package extension, use name maps #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a package extension which includes new convenience constructors for SurfaceFluxesParameters and the various UniversalFunctions parameter structs when CLIMAParameters is loaded.
The core changes are in
ext/CreateParametersExt.jl
andProject.toml
, but I have updated all of the tests and docs to work with the new constructors.This PR also alters
recover_profile
to not require aUniversalFunctionType
as an argument, since it can be obtained fromUniversalFunctionParams
within the function. With a followup PR I would like to remove the UniversalFunctionTypes (BusingerType, ChengType, etc).