-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Experiment updates and more flexible cross-validation for Paper revisions #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 88.17% 88.85% +0.67%
==========================================
Files 8 7 -1
Lines 1184 1274 +90
==========================================
+ Hits 1044 1132 +88
- Misses 140 142 +2 ☔ View full report in Codecov by Sentry. |
odunbar
force-pushed
the
orad/revision-rf-updates
branch
from
November 7, 2024 23:37
3013066
to
270010e
Compare
odunbar
changed the title
[WIP] Plotting and other changes for paper revisions
[WIP] Experiment updates and more flexible cross-validation for Paper revisions
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adjusts examples to fit referee reviews.
Content
Additionally the following src code changes were also made
n_cross_val_sets
can be set 0 for no CV, or an integerk
to performk
splits with the train-test fraction)beta
/ scaled_coeffs penalty back into the loss functionjulia v1.11
MISC
@test isapprox.(norm(μs - new_outputs), 0, atol = tol_μ)
Often the problem zeros during optimization (possibly identity issue and should be protected against this)