Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix openstack wait for fun utils v3005.1 #2

Open
wants to merge 699 commits into
base: master
Choose a base branch
from

Conversation

vdloo
Copy link
Member

@vdloo vdloo commented Oct 18, 2022

#1 again but for salt v3005.1 this time:

hotfix like saltstack#61918 but based on the https://github.com/saltstack/salt/releases/tag/v3005.1 tag

only change: fb6f87c

see related: saltstack#61918

s0undt3ch and others added 30 commits June 13, 2022 13:14
Migrate ``tests/integration/client/test_runner.py`` and ``tests/integration/wheel/`` to PyTest
* Add Ubuntu 22.04

* upgrade m2crypto requirement for linux pyversion>=3.10 to deal with build errors

* Allow signing before returning when testrun=True to cooperate with M2Crypto=0.38.0

* Skip test_py36_target when docker container resets ssh connection

* check the json stderr this time

* check raw stdout for connection closed message instead

* Actually check for the right text this time

* changelog

* Change m2crypto requirements across the board

Co-authored-by: MKLeb <[email protected]>
Co-authored-by: Caleb Beard <[email protected]>
* Add initial version report automated test

* switch to salt_cli

* move to testing parse-ability to avoid version mismatches due to (I'm assuming) different environments.  This still tests that the version report looks correct and also ensures each key that we got was expected and in the right place

* Move the test to a functional test
Twilio also had to be upgraded because it was locked to the vulnerable pyjwt version.

Signed-off-by: Pedro Algarvio <[email protected]>
Fixes saltstack#56495

Additionally, the same logic was applied to the rest_cherrypy netapi
…unt.

The reason for this extra step is to support the multiple platforms
behavior and because we remove the user from it's primary group before
deleting the account.

Signed-off-by: Pedro Algarvio <[email protected]>
Change another PosixPath for a string for Debian 9.
One more PoxixPath that needs to be a string.
Megan Wilhite and others added 23 commits September 14, 2022 02:27
… is called, even when the event is not being emitted.
…hannel otherwise there are timeout exceptions when the __master_req_channel_payload is fired and reacted on. Updating existing test to test additional sub proxy minions, adding an additional test to target all controlled sub proxies.
@vdloo vdloo changed the title Hotfix openstack wait for fun utils 3005 1 Hotfix openstack wait for fun utils v3005.1 Oct 18, 2022
@vdloo vdloo force-pushed the hotfix-openstack-wait-for-fun-utils-3005-1 branch from f202517 to a172b0a Compare October 18, 2022 15:23
@vdloo vdloo force-pushed the hotfix-openstack-wait-for-fun-utils-3005-1 branch from a172b0a to fb6f87c Compare October 18, 2022 15:25
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 3.13s
- exit code: 1

The function 'pylxd_client_get' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'pylxd_save_object' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_get' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_delete' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_rename' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_state' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_start' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_stop' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_restart' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_freeze' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_unfreeze' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_config_get' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_config_set' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_config_delete' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_device_get' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_device_add' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_device_delete' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'container_file_get' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'sync_config_devices' on 'salt/modules/lxd.py' does not have a 'CLI Example:' in it's docstring
The function 'systemd_notify_call' on 'salt/utils/process.py' does not have a docstring
The function 'default_signals' on 'salt/utils/process.py' does not have a docstring
The function 'get_package_info' on 'salt/modules/win_pkg.py' does not have a 'CLI Example:' in it's docstring
The function 'wrap_tmpl_func' on 'salt/utils/templates.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'render_jinja_tmpl' on 'salt/utils/templates.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'render_mako_tmpl' on 'salt/utils/templates.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'render_wempy_tmpl' on 'salt/utils/templates.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'ping_all_connected_minions' on 'salt/utils/master.py' does not have a docstring
The function 'get_master_key' on 'salt/utils/master.py' does not have a docstring
The function 'jinja_raise' on 'salt/utils/jinja.py' does not have a docstring
The function 'regex_escape' on 'salt/utils/jinja.py' does not have a docstring
The function 'method_call' on 'salt/utils/jinja.py' does not have a docstring
The function 'show_full_context' on 'salt/utils/jinja.py' does not have a docstring
The function 'get_pauses' on 'salt/modules/state.py' does not have a 'CLI Example:' in it's docstring
The function 'apply_' on 'salt/modules/state.py' does not have a 'CLI Example:' in it's docstring
The function 'test' on 'salt/modules/state.py' does not have a 'CLI Example:' in it's docstring
The function 'load' on 'salt/utils/yamlloader.py' does not have a docstring
The function 'verify_logs_filter' on 'salt/utils/verify.py' does not have a docstring
The function 'get_zabbix_id_mapper' on 'salt/modules/zabbix.py' does not have a 'CLI Example:' in it's docstring
The function 'substitute_params' on 'salt/modules/zabbix.py' does not have a 'CLI Example:' in it's docstring
The function 'compare_params' on 'salt/modules/zabbix.py' does not have a 'CLI Example:' in it's docstring
The function 'get_object_id_by_params' on 'salt/modules/zabbix.py' does not have a 'CLI Example:' in it's docstring
The function 'create_deployment' on 'salt/modules/kubernetesmod.py' does not have a 'CLI Example:' in it's docstring
The function 'create_pod' on 'salt/modules/kubernetesmod.py' does not have a 'CLI Example:' in it's docstring
The function 'create_service' on 'salt/modules/kubernetesmod.py' does not have a 'CLI Example:' in it's docstring
The function 'replace_deployment' on 'salt/modules/kubernetesmod.py' does not have a 'CLI Example:' in it's docstring
The function 'replace_service' on 'salt/modules/kubernetesmod.py' does not have a 'CLI Example:' in it's docstring
The function 'post_master_init' on 'salt/metaproxy/proxy.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'target' on 'salt/metaproxy/proxy.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'handle_payload' on 'salt/metaproxy/proxy.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'target_load' on 'salt/metaproxy/proxy.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'get_conn' on 'salt/utils/etcd_util.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'tree' on 'salt/utils/etcd_util.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'iter_entry_points' on 'salt/utils/entrypoints.py' does not have a docstring
The function 'name_and_version_from_entry_point' on 'salt/utils/entrypoints.py' does not have a docstring
The function 'get_parameter' on 'salt/modules/boto_ssm.py' does not have a 'CLI Example:' in it's docstring
The function 'put_parameter' on 'salt/modules/boto_ssm.py' does not have a 'CLI Example:' in it's docstring
The function 'delete_parameter' on 'salt/modules/boto_ssm.py' does not have a 'CLI Example:' in it's docstring
The function 'make_con' on 'salt/proxy/netmiko_px.py' does not have a docstring
The function 'connection' on 'salt/proxy/netmiko_px.py' does not have a docstring
The function 'banner' on 'salt/modules/slsutil.py' does not have a 'CLI Example:' in it's docstring
The function 'boolstr' on 'salt/modules/slsutil.py' does not have a 'CLI Example:' in it's docstring
The function 'list_dvss' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'create_dvs' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'update_dvs' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_dvportgroups' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_uplink_dvportgroup' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'create_dvportgroup' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'update_dvportgroup' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'remove_dvportgroup' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_storage_policies' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_default_vsan_policy' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_capability_definitions' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'create_storage_policy' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'update_storage_policy' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_default_storage_policy_of_datastore' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'assign_default_storage_policy_to_datastore' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_datacenters_via_proxy' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'create_datacenter' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_cluster' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'create_cluster' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'update_cluster' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_datastores_via_proxy' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'create_vmfs_datastore' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'rename_datastore' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'remove_datastore' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_licenses' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'add_license' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_assigned_licenses' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'assign_license' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_disks' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'erase_disk_partitions' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_disk_partitions' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'list_diskgroups' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'create_diskgroup' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'add_capacity_to_diskgroup' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'remove_capacity_from_diskgroup' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'remove_diskgroup' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'get_host_cache' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'configure_host_cache' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'get_vm' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'get_vm_config_file' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'get_advanced_configs' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'set_advanced_configs' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'delete_advanced_configs' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'compare_vm_configs' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'get_vm_config' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'update_vm' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'register_vm' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'power_on_vm' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'power_off_vm' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'delete_vm' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'unregister_vm' on 'salt/modules/vsphere.py' does not have a 'CLI Example:' in it's docstring
The function 'fqdns' on 'salt/modules/network.py' does not have a 'CLI Example:' in it's docstring
The function 'split_username' on 'salt/utils/win_runas.py' does not have a docstring
The function 'init_kwargs' on 'salt/cache/redis_cache.py' does not have a docstring
The function 'random' on 'salt/utils/stringutils.py' does not have a docstring
The function 'assumed_creds' on 'salt/utils/aws.py' does not have a docstring
The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in it's docstring
The function 'to_salt_event' on 'salt/beacons/watchdog.py' does not have a docstring
The function 'close' on 'salt/beacons/watchdog.py' does not have a docstring
The function 'nesthash' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'init' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'node_devices' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'network_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'pool_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'load' on 'salt/utils/yamlloader_old.py' does not have a docstring
The function 'help' on 'salt/modules/ansiblegate.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'list_' on 'salt/modules/ansiblegate.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'ping' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'check_password' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'check_role' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'cmd' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'find' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'get_roles' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'get_user' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'grains' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'grains_refresh' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'sendline' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'show_ver' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'show_run' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'system_info' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'add_config' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'delete_config' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'remove_user' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'replace' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'save_running_config' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'set_password' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'set_role' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'unset_role' on 'salt/modules/nxos.py' does not have a 'CLI Example:' in it's docstring
The function 'delete' on 'salt/modules/swift.py' does not have a 'CLI Example:' in it's docstring
The function 'get' on 'salt/modules/swift.py' does not have a 'CLI Example:' in it's docstring
The function 'head' on 'salt/modules/swift.py' does not have a docstring
The function 'put' on 'salt/modules/swift.py' does not have a 'CLI Example:' in it's docstring
The function 'split_comparison' on 'salt/utils/pkg/init.py' does not have a docstring
The function 'read_secret' on 'salt/modules/vault.py' does not have a 'CLI Example:' in it's docstring
Found 12 warnings
Found 143 errors


Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.