-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix openstack wait for fun utils v3006.1 #4
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Pedro Algarvio <[email protected]>
…w) and add some test coverage for the new pip install directory
…alling a package installed using `--target`
…t.yml` It's now also used to detect changes to workflows. Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
…table Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
…alled Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Create it at the right stage. Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
hotfix like saltstack#61918 but based on the https://github.com/saltstack/salt/releases/tag/v3004.1 tag
to fix: ``` salt/salt/cloud/clouds/openstack.py", line 448, in _get_ips elif addr_type == "private" and not salt.utils.cloud.is_public_ip( NameError: name 'salt' is not defined ```
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 4.07s - exit code: 1 Thanks again! |
#2 again but for salt v3006.1 this time:
hotfix like saltstack#61918 but based on the https://github.com/saltstack/salt/releases/tag/v3006.1 tag
only change: c08f270
see related: saltstack#61918