Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global binary metrics are now using a function creator, as they have … #117

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Hendrik-code
Copy link
Collaborator

  • global binary metrics are now using a function creator, as they have an underlying pattern.
  • They use the edge case handler now.
  • to allow for maximum flexibility, added a EvaluateInstancePair class which allows some functions to be easier. This way, one could jump from an instance approximation algorithm directly to results.
  • Also added global_metrics as argument so users can decide which global metrics should be calculated, default set to Dice (DSC).
  • Additionally, renamed eval_metrics to instance_metrics to distinguish it better to the global_metrics argument

…an underlying pattern. They use the edge case handler now. to allow for maximum flexibility, added a EvaluateInstancePair class which allows some functions to be easier. This way, one could jump from an instance approximation algorithm directly to results. Also added global_metrics as argument so users can decide which global metrics should be calculated, default set to Dice (DSC). Additionally, renamed eval_metrics to instance_metrics to distinguish it better to the global_metrics argument
@Hendrik-code Hendrik-code added bug Something isn't working enhancement New feature or request labels Aug 7, 2024
@Hendrik-code Hendrik-code self-assigned this Aug 7, 2024
@Hendrik-code Hendrik-code linked an issue Aug 7, 2024 that may be closed by this pull request
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Aug 7, 2024

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@Hendrik-code
Copy link
Collaborator Author

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Aug 7, 2024

🤖 I will now format your code with black. Check the status here.

@Hendrik-code Hendrik-code merged commit dcafb18 into main Aug 7, 2024
4 checks passed
@Hendrik-code Hendrik-code deleted the 105 branch August 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global metric calculations circumvent the edge case handling
1 participant