-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added convenience methods to credentials. #412
Added convenience methods to credentials. #412
Conversation
@Randy808 you may want to rebase this before you put any more work into it, some parts changed, e.g. We reintroduced the |
0291adf
to
877515c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again! Nice work @Randy808
One thing that I noticed: I think we can get rid of providing the node_id
to the scheduler
on scheduler::new()
altogether. We could add it to the Device
credentials e.g. as a trait NodeIdProvider
instead of deriving it from the tls_config
. The non-authenticated methods register
, recover
could get the node_id
from the signer
that they get. This may allow us to completely remove get_node_id_from_tls_config
.
What do you think?
Also: We may consider adding with_identity
only to the Nobody
credentials to avoid any confusion for developers about the use of the Device
credentials that should be created from bytes or path.
I am not sure if it would make sense to change the signature of Nobody::with
to use an Option
for the ca
param instead that falls back to `load_file_or_default. Let me know what you think about this.
I see a couple of discussions still ongoing, shall we draft this until the discussion has settled, or are these things that we should spin out? |
6fd4f72
to
cd1da65
Compare
8c3b847
to
9e6acde
Compare
Looks like this is runs into the cln-vm-manager issue that @ErikDeSmedt is addressing in #442. I will rebase once that's merged and merge this asap. |
9e6acde
to
400fc43
Compare
ACK 400fc43 |
No description provided.