-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build code from docs #407
Build code from docs #407
Conversation
0ab3d2c
to
c1757fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
Why is there a ca.crt
-file in python/getting-started
but not in rust/getting-started
?
The standard way to initialize credentials is by using the associated function Because specifying a CA cert every time can be tedious for the average consumer who only wants to talk to the official Greenlight server, and because we don't have instructions in our docs on manually loading up the Greenlight CA cert, I thought it would be beneficial to add a convenience functions that take care of this for the developer. The convenience method I used was In Python these fields aren't exposed so this approach doesn't work. Instead, I just put the Greenlight CA cert in the same folder as the I have another PR to make it easier to initialize a Credential without explicitly specifying the cert but I put custom functions in the docs as placeholders. It gets a little tricky with how it's done because of the |
Could we bundle the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4143b92
to
df2061f
Compare
@Randy808 how is this PR looking, can we merge it soon even if not quite perfect, we can always fix up later, as long as we don't forget about it. |
0f2f2cf
to
36f7e60
Compare
I didn't update the credentials doc but I can make that a separate issue. The only other thing on the checklist is publishing new versions of glclient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack 4ffebe6
7a6d1b3
to
4ffebe6
Compare
4ffebe6
to
0dfe6de
Compare
The docs for this branch use the latest version of the code and this shouldn't be merged yet until the below tasks have been completed.
- [ ] Update docs for creds page