-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-coin-coredao): add coredao sdk skeleton #5121
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
node_modules | ||
.idea | ||
public | ||
dist | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
node_modules/ | ||
.idea/ | ||
dist/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
require: 'ts-node/register' | ||
timeout: '120000' | ||
reporter: 'min' | ||
reporter-option: | ||
- 'cdn=true' | ||
- 'json=false' | ||
exit: true | ||
spec: ['test/unit/**/*.ts'] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
!dist/ | ||
dist/test/ | ||
dist/tsconfig.tsbuildinfo | ||
.idea/ | ||
.prettierrc.yml | ||
tsconfig.json | ||
src/ | ||
test/ | ||
scripts/ | ||
.nyc_output | ||
CODEOWNERS | ||
node_modules/ | ||
.prettierignore | ||
.mocharc.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
.nyc_output/ | ||
dist/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
printWidth: 120 | ||
singleQuote: true | ||
trailingComma: 'es5' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# BitGo sdk-coin-coredao | ||
|
||
SDK coins provide a modular approach to a monolithic architecture. This and all BitGoJS SDK coins allow developers to use only the coins needed for a given project. | ||
|
||
## Installation | ||
|
||
All coins are loaded traditionally through the `bitgo` package. If you are using coins individually, you will be accessing the coin via the `@bitgo/sdk-api` package. | ||
|
||
In your project install both `@bitgo/sdk-api` and `@bitgo/sdk-coin-coredao`. | ||
|
||
```shell | ||
npm i @bitgo/sdk-api @bitgo/sdk-coin-coredao | ||
``` | ||
|
||
Next, you will be able to initialize an instance of "bitgo" through `@bitgo/sdk-api` instead of `bitgo`. | ||
|
||
```javascript | ||
import { BitGoAPI } from '@bitgo/sdk-api'; | ||
import { Coredao } from '@bitgo/sdk-coin-coredao'; | ||
|
||
const sdk = new BitGoAPI(); | ||
|
||
sdk.register('coredao', Coredao.createInstance); | ||
``` | ||
|
||
## Development | ||
|
||
Most of the coin implementations are derived from `@bitgo/sdk-core`, `@bitgo/statics`, and coin specific packages. These implementations are used to interact with the BitGo API and BitGo platform services. | ||
|
||
You will notice that the basic version of common class extensions have been provided to you and must be resolved before the package build will succeed. Upon initiation of a given SDK coin, you will need to verify that your coin has been included in the root `tsconfig.packages.json` and that the linting, formatting, and testing succeeds when run both within the coin and from the root of BitGoJS. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{ | ||
"name": "@bitgo/sdk-coin-coredao", | ||
"version": "1.0.0", | ||
"description": "BitGo SDK coin library for Coredao", | ||
"main": "./dist/src/index.js", | ||
"types": "./dist/src/index.d.ts", | ||
"scripts": { | ||
"build": "yarn tsc --build --incremental --verbose .", | ||
"fmt": "prettier --write .", | ||
"check-fmt": "prettier --check .", | ||
"clean": "rm -r ./dist", | ||
"lint": "eslint --quiet .", | ||
"prepare": "npm run build", | ||
"test": "npm run coverage", | ||
"coverage": "nyc -- npm run unit-test", | ||
"unit-test": "mocha" | ||
}, | ||
"author": "BitGo SDK Team <[email protected]>", | ||
"license": "MIT", | ||
"engines": { | ||
"node": ">=18 <21" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/BitGo/BitGoJS.git", | ||
"directory": "modules/sdk-coin-coredao" | ||
}, | ||
"lint-staged": { | ||
"*.{js,ts}": [ | ||
"yarn prettier --write", | ||
"yarn eslint --fix" | ||
] | ||
}, | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"nyc": { | ||
"extension": [ | ||
".ts" | ||
] | ||
}, | ||
"dependencies": { | ||
"@bitgo/abstract-eth": "^22.3.2", | ||
"@bitgo/sdk-core": "^28.13.2", | ||
"@bitgo/statics": "^50.7.0", | ||
"@ethereumjs/common": "^2.6.5" | ||
}, | ||
"devDependencies": { | ||
"@bitgo/sdk-api": "^1.56.4", | ||
"@bitgo/sdk-test": "^8.0.51" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import { BaseCoin, BitGoBase, common, MPCAlgorithm } from '@bitgo/sdk-core'; | ||
import { BaseCoin as StaticsBaseCoin, coins } from '@bitgo/statics'; | ||
import { AbstractEthLikeNewCoins, recoveryBlockchainExplorerQuery } from '@bitgo/abstract-eth'; | ||
import { TransactionBuilder } from './lib'; | ||
|
||
export class Coredao extends AbstractEthLikeNewCoins { | ||
protected constructor(bitgo: BitGoBase, staticsCoin?: Readonly<StaticsBaseCoin>) { | ||
super(bitgo, staticsCoin); | ||
} | ||
|
||
static createInstance(bitgo: BitGoBase, staticsCoin?: Readonly<StaticsBaseCoin>): BaseCoin { | ||
return new Coredao(bitgo, staticsCoin); | ||
} | ||
|
||
protected getTransactionBuilder(): TransactionBuilder { | ||
return new TransactionBuilder(coins.get(this.getBaseChain())); | ||
} | ||
|
||
/** @inheritDoc */ | ||
supportsTss(): boolean { | ||
return true; | ||
} | ||
|
||
/** @inheritDoc */ | ||
getMPCAlgorithm(): MPCAlgorithm { | ||
return 'ecdsa'; | ||
} | ||
|
||
async recoveryBlockchainExplorerQuery(query: Record<string, string>): Promise<Record<string, unknown>> { | ||
const apiToken = common.Environments[this.bitgo.getEnv()].coredaoExplorerApiToken; | ||
const explorerUrl = common.Environments[this.bitgo.getEnv()].coredaoExplorerBaseUrl; | ||
return await recoveryBlockchainExplorerQuery(query, explorerUrl as string, apiToken); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export * from './lib'; | ||
export * from './coredao'; | ||
export * from './tcoredao'; | ||
export * from './register'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import * as Utils from './utils'; | ||
|
||
export { TransactionBuilder } from './transactionBuilder'; | ||
export { TransferBuilder } from './transferBuilder'; | ||
gianchandania marked this conversation as resolved.
Show resolved
Hide resolved
|
||
export { Utils }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import EthereumCommon from '@ethereumjs/common'; | ||
import { coins, EthereumNetwork } from '@bitgo/statics'; | ||
|
||
export const testnetCommon = EthereumCommon.custom( | ||
{ | ||
name: 'coredao testnet', | ||
networkId: (coins.get('tcoredao').network as EthereumNetwork).chainId, | ||
chainId: (coins.get('tcoredao').network as EthereumNetwork).chainId, | ||
}, | ||
{ | ||
baseChain: 'sepolia', | ||
hardfork: 'london', | ||
eips: [1559], | ||
} | ||
); | ||
|
||
export const mainnetCommon = EthereumCommon.custom( | ||
{ | ||
name: 'coredao mainnet', | ||
networkId: (coins.get('coredao').network as EthereumNetwork).chainId, | ||
chainId: (coins.get('coredao').network as EthereumNetwork).chainId, | ||
}, | ||
{ | ||
baseChain: 'mainnet', | ||
hardfork: 'london', | ||
eips: [1559], | ||
} | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import { BaseCoin as CoinConfig } from '@bitgo/statics'; | ||
import { BuildTransactionError, TransactionType } from '@bitgo/sdk-core'; | ||
import { TransactionBuilder as AbstractTransactionBuilder, Transaction } from '@bitgo/abstract-eth'; | ||
import { getCommon } from './utils'; | ||
import { TransferBuilder } from './transferBuilder'; | ||
|
||
export class TransactionBuilder extends AbstractTransactionBuilder { | ||
protected _transfer: TransferBuilder; | ||
|
||
constructor(_coinConfig: Readonly<CoinConfig>) { | ||
super(_coinConfig); | ||
this._common = getCommon(this._coinConfig.network.type); | ||
this.transaction = new Transaction(this._coinConfig, this._common); | ||
} | ||
|
||
/** @inheritdoc */ | ||
transfer(data?: string): TransferBuilder { | ||
if (this._type !== TransactionType.Send) { | ||
throw new BuildTransactionError('Transfers can only be set for send transactions'); | ||
} | ||
if (!this._transfer) { | ||
this._transfer = new TransferBuilder(data); | ||
} | ||
return this._transfer; | ||
} | ||
|
||
protected getContractData(addresses: string[]): string { | ||
throw new Error('Method not implemented.'); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { TransferBuilder } from '@bitgo/abstract-eth'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { NetworkType } from '@bitgo/statics'; | ||
import EthereumCommon from '@ethereumjs/common'; | ||
import { InvalidTransactionError } from '@bitgo/sdk-core'; | ||
import { testnetCommon, mainnetCommon } from './resources'; | ||
|
||
const commons: Map<NetworkType, EthereumCommon> = new Map<NetworkType, EthereumCommon>([ | ||
[NetworkType.MAINNET, mainnetCommon], | ||
[NetworkType.TESTNET, testnetCommon], | ||
]); | ||
|
||
/** | ||
* @param {NetworkType} network either mainnet or testnet | ||
* @returns {EthereumCommon} Ethereum common configuration object | ||
*/ | ||
export function getCommon(network: NetworkType): EthereumCommon { | ||
const common = commons.get(network); | ||
if (!common) { | ||
throw new InvalidTransactionError('Missing network common configuration'); | ||
} | ||
return common; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { BitGoBase } from '@bitgo/sdk-core'; | ||
import { Coredao } from './coredao'; | ||
import { Tcoredao } from './tcoredao'; | ||
|
||
export const register = (sdk: BitGoBase): void => { | ||
sdk.register('coredao', Coredao.createInstance); | ||
sdk.register('tcoredao', Tcoredao.createInstance); | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we not have some type of const that can be used instead of the hardcoded string?