feat(sdk-coin-coredao): add coredao sdk skeleton #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarsh312
force-pushed
the
WIN-3696_coredao_skeleton
branch
from
a940798 to
c92a1b7
Compare
adarsh312
force-pushed
the
WIN-3696_coredao_skeleton
branch
from
c92a1b7 to
e8c0b55
Compare
adarsh312
force-pushed
the
WIN-3696_coredao_skeleton
branch
5 times, most recently
from
2e61f3e to
1b982fb
Compare
adarsh312
force-pushed
the
WIN-3696_coredao_skeleton
branch
3 times, most recently
from
890bddf to
9f3424d
Compare
gianchandania
previously approved these changes
Nov 15, 2024
adarsh312
force-pushed
the
WIN-3696_coredao_skeleton
branch
from
9f3424d to
eaa1897
Compare
adarsh312
force-pushed
the
WIN-3696_coredao_skeleton
branch
from
eaa1897 to
0e6ce18
Compare
gianchandania
approved these changes
Nov 18, 2024
|
|
||
| /** @inheritDoc */ | ||
| getMPCAlgorithm(): MPCAlgorithm { | ||
| return 'ecdsa'; |
There was a problem hiding this comment.
nit: do we not have some type of const that can be used instead of the hardcoded string?
margueriteblair
approved these changes
Nov 18, 2024
sumanmukherjee03
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-3696