Add GET/SET/INFO/PING commands #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
requested review from
aaron-congo,
jonathanl-bq,
Yury-Fridlyand and
SanHalacogluImproving
SanHalacogluImproving
approved these changes
Jan 25, 2024
jonathanl-bq
approved these changes
Jan 25, 2024
acarbonetto
force-pushed
the
java/integ_acarbo_api_getsetinfoping
branch
from
9927bd9 to
92cd1f0
Compare
* Add base command; add custom command --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/dev_acarbo_api_getsetinfoping
branch
from
df8b07d to
926d04e
Compare
aaron-congo
reviewed
Jan 26, 2024
| * @see <a href="https://redis.io/commands/set/">redis.io</a> for details. | ||
| * @param key - The key to store. | ||
| * @param value - The value to store with the given key. | ||
| * @return null |
There was a problem hiding this comment.
nit:
Suggested change
| * @return null | |
| * @return A CompletableFuture that can be used to wait for the command to complete. Set has no return value, so the CompletableFuture will return null. |
Comment on lines
+192
to
+193
| * @return string or null If value isn't set because of `onlyIfExists` or `onlyIfDoesNotExist` | ||
| * conditions, return null. If `returnOldValue` is set, return the old value as a string. |
There was a problem hiding this comment.
Taking from the python docs:
Suggested change
| * @return string or null If value isn't set because of `onlyIfExists` or `onlyIfDoesNotExist` | |
| * conditions, return null. If `returnOldValue` is set, return the old value as a string. | |
| * @return The old value as a string of `returnOldValue` is set. Otherwise, if the value isn't set because of `onlyIfExists` or `onlyIfDoesNotExist` conditions, return null. Otherwise, return "OK". |
| /** | ||
| * Converts options enum into a String[] to add to a {@link glide.api.models.Command} | ||
| * | ||
| * @return String[] |
There was a problem hiding this comment.
Suggested change
| * @return String[] | |
| * @return The sections held by this InfoOptions as an array of strings |
Comment on lines
+34
to
+37
| * Check for errors in the Response and return null Throws an error if an unexpected value is | ||
| * returned | ||
| * | ||
| * @return null if the response is empty |
There was a problem hiding this comment.
Should we use the @throws tag here?
Suggested change
| * Check for errors in the Response and return null Throws an error if an unexpected value is | |
| * returned | |
| * | |
| * @return null if the response is empty | |
| * Check for errors in the Response and return null. | |
| * | |
| * @return null if the response is empty | |
| * @throws RedisException if an unexpected (non-null) value is returned |
Comment on lines
+95
to
+96
| * @param arguments | ||
| * @return |
There was a problem hiding this comment.
nit:
Suggested change
| * @param arguments | |
| * @return | |
| * @param arguments The desired set options | |
| * @return The passed in arguments as an array of strings |
Comment on lines
+34
to
+37
| * Check for errors in the Response and return null Throws an error if an unexpected value is | ||
| * returned | ||
| * | ||
| * @return null if the response is empty |
Comment on lines
+95
to
+96
| * @param arguments | ||
| * @return |
There was a problem hiding this comment.
Leave here tests which required for coverage only, all rest you can move to IT
|
Please, add a PR description and examples, especially for set with options and info with options. |
aaron-congo
reviewed
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.