Skip to content

Commit

Permalink
Minor comments
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Carbonetto <[email protected]>
  • Loading branch information
acarbonetto committed Jan 19, 2024
1 parent b2e7b60 commit 9927bd9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public interface BaseCommands {

/**
* Extracts the response from the Protobuf response and either throws an exception or returns the
* appropriate response has an Object
* appropriate response as an Object
*
* @param response Redis protobuf message
* @return Response Object
Expand Down
2 changes: 2 additions & 0 deletions java/client/src/main/java/glide/managers/CommandManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ public <T> CompletableFuture<T> submitNewCommand(
* Build a protobuf command/transaction request object.<br>
* Used by {@link CommandManager}.
*
* @param command - Redis command
* @param args - Redis command arguments as string array
* @return An uncompleted request. CallbackDispatcher is responsible to complete it by adding a
* callback id.
*/
Expand Down
2 changes: 0 additions & 2 deletions java/client/src/test/java/glide/api/RedisClientTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ public void customCommand_success() throws ExecutionException, InterruptedExcept
// verify
assertEquals(testResponse, response);
assertEquals(value, payload);

// teardown
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public void submitNewCommand_returnNullResult() throws ExecutionException, Inter
command, new BaseCommandResponseResolver((p) -> new RuntimeException("")));
Object respPointer = result.get();

// verify
assertNull(respPointer);
}

Expand Down

0 comments on commit 9927bd9

Please sign in to comment.