Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zKube, rename zKrown #297

Closed
wants to merge 1 commit into from
Closed

Add zKube, rename zKrown #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions packages/constants/src/Games.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,15 @@ export const games: Game[] = [
playable: true,
},
{
name: "zConqueror",
id: "zconqueror",
name: "zKrown",
id: "zkrown",
developer: Studios.ZKORP,
genres: ["Strategy", "PvP", "Casual"],
color: "#f5f5f5",
status: "beta",
description: "Conquer the world",
longform:
"zConqueror is a strategy game based on Risk, focusing on conquest and realm defense. Players compete to dominate the map and win rewards. You can compete up to 6 players",
"zKrown is a strategy game based on Risk, focusing on conquest and realm defense. Players compete to dominate the map and win rewards. You can compete up to 6 players",
links: {
twitter: "https://twitter.com/zKorp_",
homepage: "https://app.zconqueror.xyz/",
Expand All @@ -171,6 +171,26 @@ export const games: Game[] = [
tokens: [Tokens.LORDS],
screenshotLength: 4,
playable: true,
},
{
name: "zKube",
id: "zKube",
developer: Studios.ZKORP,
genres: ["Strategy", "Mobile", "Casual"],
color: "#085f9b",
status: "mainnet",
description: "Chill with this casual puzzle game",
longform:
"zKube is a casual puzzle game you can play on your mobile seemlesly. Join the daily or monthly tournament to conquer the leaderboard and ear rewards!",
links: {
twitter: "https://x.com/zKube_game",
homepage: "https://app.zkube.xyz/",
},
chains: [ChainId.SLOT_TESTNET, ChainId.SN_MAIN],
operatingSystems: ["Web Browser"],
tokens: [Tokens.LORDS],
screenshotLength: 4,
playable: true,
Comment on lines +175 to +193
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

New game entry looks good! A few minor adjustments needed.

The addition of the "zKube" game entry is great! It follows the structure of other game entries and provides all the necessary information. However, there are a few minor issues to address:

  1. The id should be lowercase for consistency with other entries.
  2. There are two typos in the longform description.

Please apply the following changes:

-    id: "zKube",
+    id: "zkube",
     // ... (other fields remain the same)
     longform:
-      "zKube is a casual puzzle game you can play on your mobile seemlesly. Join the daily or monthly tournament to conquer the leaderboard and ear rewards!",
+      "zKube is a casual puzzle game you can play on your mobile seamlessly. Join the daily or monthly tournament to conquer the leaderboard and earn rewards!",

These changes will improve consistency and correct the typos in the description.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
name: "zKube",
id: "zKube",
developer: Studios.ZKORP,
genres: ["Strategy", "Mobile", "Casual"],
color: "#085f9b",
status: "mainnet",
description: "Chill with this casual puzzle game",
longform:
"zKube is a casual puzzle game you can play on your mobile seemlesly. Join the daily or monthly tournament to conquer the leaderboard and ear rewards!",
links: {
twitter: "https://x.com/zKube_game",
homepage: "https://app.zkube.xyz/",
},
chains: [ChainId.SLOT_TESTNET, ChainId.SN_MAIN],
operatingSystems: ["Web Browser"],
tokens: [Tokens.LORDS],
screenshotLength: 4,
playable: true,
{
name: "zKube",
id: "zkube",
developer: Studios.ZKORP,
genres: ["Strategy", "Mobile", "Casual"],
color: "#085f9b",
status: "mainnet",
description: "Chill with this casual puzzle game",
longform:
"zKube is a casual puzzle game you can play on your mobile seamlessly. Join the daily or monthly tournament to conquer the leaderboard and earn rewards!",
links: {
twitter: "https://x.com/zKube_game",
homepage: "https://app.zkube.xyz/",
},
chains: [ChainId.SLOT_TESTNET, ChainId.SN_MAIN],
operatingSystems: ["Web Browser"],
tokens: [Tokens.LORDS],
screenshotLength: 4,
playable: true,

},
{
name: "Underdark",
Expand Down
Loading