-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zKube, rename zKrown #297
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes involve updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
packages/constants/src/Games.ts (1)
Line range hint
156-174
: LGTM! Minor suggestion for description improvement.The changes to rename "zConqueror" to "zKrown" have been implemented consistently. The id has been updated appropriately, and the description has been modified to reflect the new name.
Consider refining the description for better clarity:
- "zKrown is a strategy game based on Risk, focusing on conquest and realm defense. Players compete to dominate the map and win rewards. You can compete up to 6 players", + "zKrown is a strategy game inspired by Risk, focusing on conquest and realm defense. Players compete to dominate the map and win rewards. Supports up to 6 players in multiplayer matches.",
{ | ||
name: "zKube", | ||
id: "zKube", | ||
developer: Studios.ZKORP, | ||
genres: ["Strategy", "Mobile", "Casual"], | ||
color: "#085f9b", | ||
status: "mainnet", | ||
description: "Chill with this casual puzzle game", | ||
longform: | ||
"zKube is a casual puzzle game you can play on your mobile seemlesly. Join the daily or monthly tournament to conquer the leaderboard and ear rewards!", | ||
links: { | ||
twitter: "https://x.com/zKube_game", | ||
homepage: "https://app.zkube.xyz/", | ||
}, | ||
chains: [ChainId.SLOT_TESTNET, ChainId.SN_MAIN], | ||
operatingSystems: ["Web Browser"], | ||
tokens: [Tokens.LORDS], | ||
screenshotLength: 4, | ||
playable: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New game entry looks good! A few minor adjustments needed.
The addition of the "zKube" game entry is great! It follows the structure of other game entries and provides all the necessary information. However, there are a few minor issues to address:
- The
id
should be lowercase for consistency with other entries. - There are two typos in the
longform
description.
Please apply the following changes:
- id: "zKube",
+ id: "zkube",
// ... (other fields remain the same)
longform:
- "zKube is a casual puzzle game you can play on your mobile seemlesly. Join the daily or monthly tournament to conquer the leaderboard and ear rewards!",
+ "zKube is a casual puzzle game you can play on your mobile seamlessly. Join the daily or monthly tournament to conquer the leaderboard and earn rewards!",
These changes will improve consistency and correct the typos in the description.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
{ | |
name: "zKube", | |
id: "zKube", | |
developer: Studios.ZKORP, | |
genres: ["Strategy", "Mobile", "Casual"], | |
color: "#085f9b", | |
status: "mainnet", | |
description: "Chill with this casual puzzle game", | |
longform: | |
"zKube is a casual puzzle game you can play on your mobile seemlesly. Join the daily or monthly tournament to conquer the leaderboard and ear rewards!", | |
links: { | |
twitter: "https://x.com/zKube_game", | |
homepage: "https://app.zkube.xyz/", | |
}, | |
chains: [ChainId.SLOT_TESTNET, ChainId.SN_MAIN], | |
operatingSystems: ["Web Browser"], | |
tokens: [Tokens.LORDS], | |
screenshotLength: 4, | |
playable: true, | |
{ | |
name: "zKube", | |
id: "zkube", | |
developer: Studios.ZKORP, | |
genres: ["Strategy", "Mobile", "Casual"], | |
color: "#085f9b", | |
status: "mainnet", | |
description: "Chill with this casual puzzle game", | |
longform: | |
"zKube is a casual puzzle game you can play on your mobile seamlessly. Join the daily or monthly tournament to conquer the leaderboard and earn rewards!", | |
links: { | |
twitter: "https://x.com/zKube_game", | |
homepage: "https://app.zkube.xyz/", | |
}, | |
chains: [ChainId.SLOT_TESTNET, ChainId.SN_MAIN], | |
operatingSystems: ["Web Browser"], | |
tokens: [Tokens.LORDS], | |
screenshotLength: 4, | |
playable: true, |
Summary by CodeRabbit