Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eager loading of scoped associations. Previously the scope was no… #67

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

asedge
Copy link
Collaborator

@asedge asedge commented Sep 25, 2023

…t applied. Scopes that accept arguments cannot be used as they are expecting an instance to be passed to them and if we are eager loading there is no instance to reference.

…t applied. Scopes that accept arguments cannot be used as they are expecting an instance to be passed to them and if we are eager loading there is no instance to reference.
@asedge asedge force-pushed the fix_eager_load_of_scoped_associations branch from b750876 to e57147b Compare September 26, 2023 13:54
@asedge asedge requested a review from swpreethi September 26, 2023 14:24
@asedge asedge removed the request for review from swpreethi September 28, 2023 17:49
Copy link
Contributor

@bfrey08 bfrey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bfrey08 bfrey08 merged commit 5c26202 into main Sep 29, 2023
2 checks passed
@bfrey08 bfrey08 deleted the fix_eager_load_of_scoped_associations branch September 29, 2023 15:28
Copy link

@salonishah23 salonishah23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This def opens up the possibilities of using eager loading correctly. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants