Fixes #91. Applies scopes to eager-loaded associations when they are nested. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfrey08
reviewed
Mar 22, 2024
| SELECT Id, Name, Link__c, | ||
| (SELECT Id, Title__c, BlogId, IsActive, | ||
| (SELECT Id, PostId, PosterId__c, FancyPostId, Body__c | ||
| FROM Comments__r WHERE (1 = 0)) |
There was a problem hiding this comment.
😄 it was one of the pre-defined scopes from the original authors
bfrey08
approved these changes
Mar 22, 2024
swpreethi
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have previously fixed the eager loading of scoped associations (#67). The way the query was built when using includes with association nesting is different so it only worked if you didn't try to nest anything above it (e.g.
includes(:scoped_association)and notincludes(scoped_association: :child). I did a bit of a refactor to align them so the latter example will now work and because it's called recursively the scopes will be applied all the way down the chain.