FT-10 Lab Result #13
Open
FT-10 Lab Result #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 27, 2022 19:58
taufiqkba
reviewed
Jul 3, 2022
| @@ -0,0 +1,115 @@ | |||
| require 'rails_helper' | |||
|
|
|||
There was a problem hiding this comment.
Saran dari mentor kemarin, nice to have kalo spec/request dipindah ke folder spec/controller dan namanya ngikut nama file controller-nya dikasih suffix _spec. Biar seragam semua penamaan folder/file nya
taufiqkba
reviewed
Jul 3, 2022
| @@ -0,0 +1,15 @@ | |||
| require 'rails_helper' | |||
There was a problem hiding this comment.
better di hapus filenya kalau tidak digunakan.
afandiaziz
reviewed
Jul 3, 2022
| @@ -0,0 +1,2 @@ | |||
| module LabMeasurementHelper | |||
There was a problem hiding this comment.
file yang tidak digunakan bisa di hapus mas
afandiaziz
reviewed
Jul 3, 2022
| @@ -0,0 +1,2 @@ | |||
| module LabResultCategoriesHelper | |||
There was a problem hiding this comment.
file yang tidak digunakan bisa di hapus mas
afandiaziz
reviewed
Jul 3, 2022
| @@ -0,0 +1,2 @@ | |||
| module LabResultsHelper | |||
There was a problem hiding this comment.
file yang tidak digunakan bisa di hapus mas
afandiaziz
reviewed
Jul 3, 2022
| expect(labresult).to be_valid | ||
| end | ||
| end | ||
| describe '-- UPDATE Lab Result' do |
There was a problem hiding this comment.
test case update lab result bisa dihapus mas, karena saya lihat di routenya tidak tidak ada update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.