Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventGrid] keyvault required/optional #30933

Merged
merged 7 commits into from
Dec 3, 2024
Merged

[EventGrid] keyvault required/optional #30933

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39029a5
required
l0lawrence Oct 9, 2024
b3f5221
add made required on value types
l0lawrence Nov 19, 2024
46aa142
Merge branch 'main' into keyvault_required
l0lawrence Dec 3, 2024
0433ab0
Merge branch 'main' into keyvault_required
lmazuel Dec 3, 2024
c441725
tsp format
l0lawrence Dec 3, 2024
454ca3f
Merge branch 'main' into keyvault_required
l0lawrence Dec 3, 2024
988b3e5
Merge branch 'main' into keyvault_required
l0lawrence Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions ...fication/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.KeyVault/KeyVault.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import "@typespec/versioning";
using TypeSpec.Versioning;
/** Describes the schema of the Azure Key Vault events published to Azure Event Grid. This corresponds to the Data property of an EventGridEvent. */
namespace Microsoft.EventGrid.SystemEvents {
/** Schema of the Data property of an EventGridEvent for a Microsoft.KeyVault.CertificateNewVersionCreated event. */
Expand Down Expand Up @@ -53,30 +55,32 @@ namespace Microsoft.EventGrid.SystemEvents {
alias KeyVaultCertificateBase = {
/** The id of the object that triggered this event. */
#suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
Id?: string;
Id: string;

/** Key vault name of the object that triggered this event. */
#suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
VaultName?: string;
VaultName: string;

/** The type of the object that triggered this event */
#suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
ObjectType?: string;
ObjectType: string;

/** The name of the object that triggered this event */
#suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
ObjectName?: string;
ObjectName: string;

/** The version of the object that triggered this event */
#suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
Version?: string;
Version: string;

/** Not before date of the object that triggered this event */
@madeRequired(ServiceApiVersions.v2024_01_01)
#suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
NBF?: float32;
NBF: float32;
l0lawrence marked this conversation as resolved.
Show resolved Hide resolved

/** The expiration date of the object that triggered this event */
@madeRequired(ServiceApiVersions.v2024_01_01)
#suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
EXP?: float32;
EXP: float32;
};
}
90 changes: 80 additions & 10 deletions ...ion/eventgrid/data-plane/Microsoft.EventGrid/stable/2018-01-01/GeneratedSystemEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5441,7 +5441,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultCertificateExpiredEventData": {
"type": "object",
Expand Down Expand Up @@ -5477,7 +5484,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultCertificateNearExpiryEventData": {
"type": "object",
Expand Down Expand Up @@ -5513,7 +5527,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultCertificateNewVersionCreatedEventData": {
"type": "object",
Expand Down Expand Up @@ -5549,7 +5570,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultKeyExpiredEventData": {
"type": "object",
Expand Down Expand Up @@ -5585,7 +5613,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultKeyNearExpiryEventData": {
"type": "object",
Expand Down Expand Up @@ -5621,7 +5656,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultKeyNewVersionCreatedEventData": {
"type": "object",
Expand Down Expand Up @@ -5657,7 +5699,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultSecretExpiredEventData": {
"type": "object",
Expand Down Expand Up @@ -5693,7 +5742,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultSecretNearExpiryEventData": {
"type": "object",
Expand Down Expand Up @@ -5729,7 +5785,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"KeyVaultSecretNewVersionCreatedEventData": {
"type": "object",
Expand Down Expand Up @@ -5765,7 +5828,14 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version"
]
},
"MachineLearningServicesDatasetDriftDetectedEventData": {
"type": "object",
Expand Down
110 changes: 100 additions & 10 deletions ...ion/eventgrid/data-plane/Microsoft.EventGrid/stable/2024-01-01/GeneratedSystemEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5539,7 +5539,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultCertificateExpiredEventData": {
"type": "object",
Expand Down Expand Up @@ -5575,7 +5584,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultCertificateNearExpiryEventData": {
"type": "object",
Expand Down Expand Up @@ -5611,7 +5629,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultCertificateNewVersionCreatedEventData": {
"type": "object",
Expand Down Expand Up @@ -5647,7 +5674,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultKeyExpiredEventData": {
"type": "object",
Expand Down Expand Up @@ -5683,7 +5719,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultKeyNearExpiryEventData": {
"type": "object",
Expand Down Expand Up @@ -5719,7 +5764,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultKeyNewVersionCreatedEventData": {
"type": "object",
Expand Down Expand Up @@ -5755,7 +5809,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultSecretExpiredEventData": {
"type": "object",
Expand Down Expand Up @@ -5791,7 +5854,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultSecretNearExpiryEventData": {
"type": "object",
Expand Down Expand Up @@ -5827,7 +5899,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"KeyVaultSecretNewVersionCreatedEventData": {
"type": "object",
Expand Down Expand Up @@ -5863,7 +5944,16 @@
"format": "float",
"description": "The expiration date of the object that triggered this event"
}
}
},
"required": [
"Id",
"VaultName",
"ObjectType",
"ObjectName",
"Version",
"NBF",
"EXP"
]
},
"MachineLearningServicesDatasetDriftDetectedEventData": {
"type": "object",
Expand Down
Loading