Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventGrid] keyvault required/optional #30933

Merged
merged 7 commits into from
Dec 3, 2024
Merged

[EventGrid] keyvault required/optional #30933

merged 7 commits into from
Dec 3, 2024
+191 −27

Conversation

l0lawrence
Copy link
Member

No description provided.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=937c84b7d0ae488b8316fb69768ed204
Python azure-eventgrid https://apiview.dev/Assemblies/Review/c554ddbabc6e40348998b1656e0ff585?revisionId=d3bfe658ce5b49a597fc47868aec5c7c
TypeSpec Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/bf48b2982ff74cd796f5900a221af2d5?revisionId=69242d3bb7c24b5ba9d8864ebccb4865

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec labels Oct 9, 2024
This was referenced Oct 9, 2024
Draft
Draft
@azure-sdk azure-sdk mentioned this pull request Nov 19, 2024
Draft
@lmazuel lmazuel added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Dec 3, 2024
@l0lawrence l0lawrence marked this pull request as ready for review December 3, 2024 18:47
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ApiCenter

@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Dec 3, 2024
lmazuel
lmazuel approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with service team

@lmazuel lmazuel added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Dec 3, 2024
@lmazuel lmazuel merged commit 9a31df4 into Azure:main Dec 3, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

Assignees
No one assigned
Labels
BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane Event Grid PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l0lawrence @azure-sdk @lmazuel @AzureRestAPISpecReview