This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 690eb6c.
…erts commit 26a9ab4. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch gazebo_sim # Your branch is ahead of 'origin/gazebo_sim' by 2 commits. # (use "git push" to publish your local commits) # # Changes to be committed: # deleted: src/gazebo_sim/DtSamples/drive/CMakeLists.txt # deleted: src/gazebo_sim/DtSamples/drive/package.xml # deleted: src/gazebo_sim/DtSamples/drive/src/drive.py # deleted: src/gazebo_sim/DtSamples/drive/src/stop_obstacle.py # deleted: src/gazebo_sim/DtSamples/drive/src/teleop_to_drive.py # deleted: src/gazebo_sim/DtSamples/dtmessage/CMakeLists.txt # deleted: src/gazebo_sim/DtSamples/dtmessage/msg/simple_dist.msg # deleted: src/gazebo_sim/DtSamples/dtmessage/package.xml # deleted: src/gazebo_sim/ackermann_msgs/CHANGELOG.rst # deleted: src/gazebo_sim/ackermann_msgs/CMakeLists.txt # deleted: src/gazebo_sim/ackermann_msgs/README.rst # deleted: src/gazebo_sim/ackermann_msgs/mainpage.dox # deleted: src/gazebo_sim/ackermann_msgs/msg/AckermannDrive.msg # deleted: src/gazebo_sim/ackermann_msgs/msg/AckermannDriveStamped.msg # deleted: src/gazebo_sim/ackermann_msgs/package.xml # modified: src/gazebo_sim/racecar_control/scripts/keyboard_teleop.py # modified: src/gazebo_sim/racecar_control/scripts/servo_commands.py # # Untracked files: # src/gazebo_sim/racecar/config/ #
alanssitis
suggested changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error encountered when running. Remember that python2 is not supported on noetic, thus it is not installed in the environment. Let me know if that's something that should change (i.e. install python2 in the container, etc.). Could you link the documents you used to build this so I can take a deeper look into this if possible?
alanssitis
approved these changes
Apr 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
This implements #16, adds a Gazebo simulator for the kart with simple input and output topics. We may want to consider adding textures and lighting to the scene to provide RTABmap more keypoints.
The simulator creates its own TF tree, but this should not be integrated with the existing TF as the simulator is a black box.
Is this fixing an issue?
Closes #16
Were any issues created as a result of this change?
See #43
Are there more details that are relevant?
Check lists (check x in [ ] of list items)
For each of these items, please refer to the software style guide
Any additional comments?