Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update emogrifier #2809

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Update emogrifier #2809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3f9d8e2
Add emogrifier through composer
mikeyarce Apr 20, 2024
eb103a5
New script for plugin build to include composer dependencies
mikeyarce Apr 20, 2024
3a94a31
Remove previous emogrifier library
mikeyarce Apr 20, 2024
c78d26b
Switch email notifications to new emogrifier class
mikeyarce Apr 20, 2024
9ba02ad
Build assets during plugin build
mikeyarce Apr 20, 2024
09025da
Fix github action for build
mikeyarce Apr 20, 2024
7f3f050
Make `get_styles` only returns a string
mikeyarce Apr 20, 2024
95a4579
Remove old emogrifier library from psalm
mikeyarce Apr 20, 2024
695ac89
Fix build upload
mikeyarce Apr 20, 2024
856bbf4
Remove comment specificity
mikeyarce Apr 24, 2024
b243532
Remove variable for class check
mikeyarce Apr 24, 2024
9215cf6
Remove archive commands
mikeyarce Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Build Plugin
run: npm run build
- name: Decompress plugin
run: unzip wp-job-manager.zip -d wp-job-manager
run: unzip build/wp-job-manager.zip -d wp-job-manager
- name: Store Artifact
uses: actions/upload-artifact@v2
with:
Expand Down
15 changes: 0 additions & 15 deletions .psalm/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,21 +402,6 @@
<code><![CDATA[! defined( 'ABSPATH' )]]></code>
</ParadoxicalCondition>
</file>
<file src="lib/emogrifier/class-emogrifier.php">
<InvalidArgument>
<code><![CDATA[function ($matches) use (&$media) {
$media .= $matches[0];
}]]></code>
<code><![CDATA[usort($cssRules, [$this, 'sortBySelectorPrecedence'])]]></code>
</InvalidArgument>
<InvalidReturnStatement>
<code><![CDATA[$this->caches[self::CACHE_KEY_CSS][$cssKey]]]></code>
<code><![CDATA[$this->caches[self::CACHE_KEY_SELECTOR][$selectorKey]]]></code>
</InvalidReturnStatement>
<RedundantCondition>
<code><![CDATA[$node->parentNode && is_callable([$node->parentNode, 'removeChild'])]]></code>
</RedundantCondition>
</file>
<file src="lib/usage-tracking/class-wp-job-manager-usage-tracking-base.php">
<FalsableReturnStatement>
<code>false</code>
Expand Down
29 changes: 3 additions & 26 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,38 +17,15 @@
"vimeo/psalm": "^5.13",
"php-stubs/wordpress-stubs": "^6.4"
},
"archive": {
"exclude": [
"/*",
"!/assets/dist",
"!/assets/images",
"!/assets/lib",
"/assets/dist/css/*.js",
"!/includes",
"!/languages",
"!/lib",
"!/templates",
"!/changelog.txt",
"!/LICENSE",
"!/readme.txt",
"!/uninstall.php",
"!/wp-job-manager.php",
"!/wp-job-manager-autoload.php",
"!/wp-job-manager-deprecated.php",
"!/wp-job-manager-functions.php",
"!/wp-job-manager-template.php",
"!/wpml-config.xml",
".DS_Store",
".*",
"*.test.js"
]
},
"config": {
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true
},
"platform": {
"php": "7.4"
}
},
"require": {
"pelago/emogrifier": "^7.2"
}
}
Loading
Loading