-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emogrifier #2809
Update emogrifier #2809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well! Left a few comments
@@ -34,7 +34,7 @@ | |||
"zx": "^7.2.3" | |||
}, | |||
"scripts": { | |||
"build": "npm run build:assets && npm run archive", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we are going to replace the archive command? If this is the case, maybe it makes sense to remove the archive.exclude
arguments from composer.json? Keep in mind although it is called exclude we do a !
so they are actually includes.
We should also remove the old archive command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9215cf6
Thanks @gikaragia - made the changes 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #2755
Changes Proposed in this Pull Request
Testing Instructions
npm run build
npm run build:assets && npm run archive
which is the previous build and check folders to make sure it's what we expect. It should be identical except for thetests
are gone from theusage-tracking
folder, and now we do include thevendor
folder for emogrifier.Here is my folder comparison including hidden files:
Example of margin:
Release Notes