Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ItemLink Name to 16 Characters #4318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Limit ItemLink Name to 16 Characters #4318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d63a923
Itemlink size 16
Exempt-Medic Dec 1, 2024
c4dddb5
Improve error message
Exempt-Medic Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,8 +1387,10 @@ def verify(self, world: typing.Type[World], player_name: str, plando_options: "P
super(ItemLinks, self).verify(world, player_name, plando_options)
existing_links = set()
for link in self.value:
link["name"] = link["name"].strip()[:16].strip()
if link["name"] in existing_links:
raise Exception(f"You cannot have more than one link named {link['name']}.")
raise Exception(f"Item link names are limited to their first 16 characters and must be unique. "
f"You have more than one link named '{link['name']}'.")
existing_links.add(link["name"])

pool = self.verify_items(link["item_pool"], link["name"], "item_pool", world)
Expand Down
Loading