Limit ItemLink Name to 16 Characters

[Exempt-Medic]

What is this fixing or adding?

Aliases and player names are both limited to 16 characters, however, ItemLink names are not. This truncates them to sixteen characters as well.

Also changes the error message to be more specific about the conditions for identical item link names and adds quotation marks around the name itself.

How was this tested?

Not all that much, generating an itemlink with the name "Just A Really Long Name" and both generating and uploading a world on a local webhost using the same itemlink group. Checked that the name everywhere had been shortened and connected to the multiworld to get some checks.

[Jarno458]

We never truncated item and location names tbh

[NewSoupVi]

This will result in weird exceptions when the name overlaps, right? I wonder if the Exception could be a bit more verbose here

Something like this (extremely loose and unoptimized code)

if len(name) > 16:
    name = name[:16]
    if name in ...:
        raise Exception("After being truncated, the name already exists. Item link names must differ in the first 16 characters")
    ...

Then again I'm often quite a lot more prone to writing a million user friendly exceptions than other devs, so maybe this is not necessary

[Exempt-Medic]

We never truncated item and location names tbh

An alias and player name can be shown when getting .player from something. They were limited to avoid breaking various games/clients, but itemlinks breaks them anyway

[Exempt-Medic]

This will result in weird exceptions when the name overlaps, right? I wonder if the Exception could be a bit more verbose here

Could do that, I just borrowed the already used barebones style

Archipelago/Generate.py

Line 295 in f26cda0

new_name = new_name.strip()[:16].strip()

Archipelago/Generate.py

Line 296 in f26cda0

if new_name == "Archipelago":

Archipelago/Generate.py

Line 297 in f26cda0

raise Exception(f"You cannot name yourself \"{new_name}\"")

[Exempt-Medic]

if len(name) > 16:
    name = name[:16]
    if name in ...:
        raise Exception("After being truncated, the name already exists. Item link names must differ in the first 16 characters")
    ...

So this isn't technically true because of names like " I Had Spaces At The Start". But I doubt the specificity of the exact requirements is worth putting into the error message, so "the first 16 characters" sounds great