HK: Overflow approach to fix remove on split cloak #4024
+733
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # worlds/hk/__init__.py HK: fix up split mothwing cloak logic HK: fix up potential if tree issues
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
waiting-on: author
|
This has conflicts btw |
|
test failures are the ones about extra split cloaks in pool as mentioned in the post FYI |
Exempt-Medic
removed
the
waiting-on: author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
uses the framework from #1844 to get a functioning collect/remove for split cloak and updates the code to work with modern ap code
adds first pass (there's a reason I hadn't PRd them yet) tests to HK including a suite of tests to confirm cloak collect/remove is functioning as intended
Note: this is currently failing some of the added tests because I wanted to have minimal testing for extra cloaks in the pool, something that this approach doesn't currently handle well. But I'm on the fence if that's necessary or not
Bonus Note: there are more item/effects that we need to conditionally collect as part of the hk rework, so a more generalized approach will supersede this anyways
How was this tested?
ran the tests i added
If this makes graphical changes, please attach screenshots.