HK: Recalculate effects on Remove to fix split cloak #4025
+753
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove just recalculates what collect would have done to get to the state it is at
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
alternative to #4024 that looks a lot less graceful but should cover any potential situation
has the same tests as 4024 but approaches the collect/remove fundamentally differently
Note: also has the same bonus caveat in 4024, that the rework will also just rewrite this approach as well.
the approach is simply define logic for calculating the effects based on the full items, and recalculate the effects whenever an item in collect/removed that would affect them
How was this tested?
run the added tests
If this makes graphical changes, please attach screenshots.