Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: purge py3.8 and py3.9 #3973

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Core: purge py3.8 and py3.9 #3973

merged 9 commits into from
Nov 27, 2024

Conversation

Berserker66
Copy link
Member

@Berserker66 Berserker66 commented Sep 21, 2024

What is this fixing or adding?

Fixes py 3.8 and py 3.9 by yeeting them.
Fixes Windows 7 support, by no longer supporting it.

I touched HK because I wrote that code, I saw stardew has 3.8 stuff too, didn't touch that. There's a couple more 3.8 marked todos, I left some of them alone as they either go beyond deprecation (redesign/changes) or had a question mark. Once we know what to do with those, I suppose those changes could target this branch and we can accumulate it.

How was this tested?

A bit of generate and webhost, but it's probably too early to broadly test at this time.
I also don't currently know why this fails:
image

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Sep 21, 2024
@Exempt-Medic Exempt-Medic added is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: author Issue/PR is waiting for feedback or changes from its author. labels Sep 21, 2024
Copy link
Contributor

@silasary silasary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting

@Exempt-Medic Exempt-Medic removed the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Sep 21, 2024
@agilbert1412
Copy link
Collaborator

Could you elaborate on what Stardew does / needs to do?

@Exempt-Medic
Copy link
Member

Exempt-Medic commented Sep 21, 2024

Could you elaborate on what Stardew does / needs to do?

There's at least

importlib_resources; python_version <= '3.8'

graphlib_backport; python_version <= '3.8'

Also maybe these:


# FIXME this should just be an optional field, but kw_only requires python 3.10...

@Berserker66
Copy link
Member Author

image
I don't currently intend to do anything about this, if github is still using an old version by the time this is ready for merge, we can adjust it then.

@agilbert1412
Copy link
Collaborator

@Jouramie Just pinging you to keep you in the loop, you're generally much more aware than me of how these things work

@Jouramie
Copy link
Contributor

Yeah there are a couple of things to clean up in stardew, nothing big.

@Berserker66 Berserker66 mentioned this pull request Oct 16, 2024
9 tasks
@black-sliver black-sliver added this to the Archipelago 0.6.0 milestone Oct 17, 2024
@Berserker66 Berserker66 marked this pull request as ready for review November 26, 2024 20:40
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for us to have the build on 3.10? With 3.8 we had stuff that worked on source but specifically broke frozen but I don't think it's relevant here. I think just moving this up to 3.12 makes more sense since that's what we actually ship and we'll probably want to use this action as part of the "nightly"s

Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, hopefully that's all of the 3.8/3.9 dependent code.

To be safe, I also pulled and did a quick test of generating, hosting, and running a couple clients and they seem to work fine.

Copy link
Member

@NewSoupVi NewSoupVi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's actually go I am pogged out of my gourd

@Berserker66 Berserker66 merged commit 334781e into main Nov 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants