Core: CollectionState - Never pick up advancements #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
affects: core
|
Sorry for the auto-request 🤷 |
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
is: enhancement
qwint
reviewed
Aug 13, 2024
NewSoupVi
commented
Aug 13, 2024
worlds/AutoWorld.py
Outdated
| state.prog_items[self.player][name] -= 1 | ||
| if state.prog_items[self.player][name] < 1: | ||
| del (state.prog_items[self.player][name]) | ||
| return True # Backwards compatibility, this used to denote whether a progression item was picked up |
There was a problem hiding this comment.
The only part I'm not happy with - All the overridden world collects are relying on the World collect returning "True" on an advancement, so I can't get rid of return True in favor of return, despite the fact Python is happy with an overridden function returning something different
If someone has some idea of how to get around this, let me know
NewSoupVi
added
is: refactor/cleanup
qwint
added a commit
to qwint/Archipelago
that referenced
this pull request
Sep 5, 2024
NewSoupVi
pushed a commit
that referenced
this pull request
Sep 5, 2024
* speed up collect, will be obsolete after #3786 * vi's a meanie
Exempt-Medic
added
the
waiting-on: author
NewSoupVi
force-pushed
the
never_collect_non_advancements
branch
from
398fffb to
71ccc9d
Compare
NewSoupVi
removed
the
waiting-on: author
Comment on lines
+519
to
+520
| if state.prog_items[self.player][name] < 1: | ||
| del (state.prog_items[self.player][name]) |
There was a problem hiding this comment.
3.10 should mean this is fine now?
Suggested change
| if state.prog_items[self.player][name] < 1: | |
| del (state.prog_items[self.player][name]) |
NewSoupVi
added
the
waiting-on: author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can kinda "just do this" now, if we accept that we have to change some worlds