Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HK: speed up collect (a bit) #3886

Merged
merged 2 commits into from
Sep 5, 2024
Merged

HK: speed up collect (a bit) #3886

merged 2 commits into from
Sep 5, 2024

Conversation

qwint
Copy link
Contributor

@qwint qwint commented Sep 5, 2024

What is this fixing or adding?

speed up collect, will be obsolete after #3786

considered just indenting it instead but whitespace changes are annoying

How was this tested?

ran some tests (i haven't committed yet) and they ran faster

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 5, 2024
Exempt-Medic
Exempt-Medic approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, for now.

@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. is: refactor/cleanup Improvements to code/output readability or organizization. and removed is: refactor/cleanup Improvements to code/output readability or organizization. labels Sep 5, 2024
ScipioWright
ScipioWright approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather the indent too but you've addressed that so lgtm

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 5, 2024
@NewSoupVi
Copy link
Member

Ok so yes please indent that, otherwise this is good of course

NewSoupVi
NewSoupVi approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@NewSoupVi NewSoupVi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@NewSoupVi NewSoupVi merged commit e984583 into ArchipelagoMW:main Sep 5, 2024
18 checks passed
@qwint qwint deleted the hk_speed_up_collect branch September 5, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qwint @NewSoupVi @ScipioWright @Exempt-Medic