LADX: Adding 'Option Groups' to the player options page. #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
There was a problem hiding this comment.
Personally, I think the option groups should be in order of "importance". If I were doing it, I would do: Goal, Shuffles, Warp Points, Miscellaneous, Experimental, then Visuals & Sound.
Visuals & Sound goes at the bottom since it does not affect logic. Experimental is last of the logic-affecting ones because it is Experimental -- it is options that the average player should probably not touch unless they know what they're getting into.
|
Ordered the options aroundish the original fields. And misc sounded like something for the end. But true, that still effects the logic. So moved it above as suggested. |
NewSoupVi
approved these changes
Jun 19, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…MW#3560) * Adding 'Option Groups' to the LADX player options page. * Moved 'Miscellaneous' group to the logic effecting groups.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…MW#3560) * Adding 'Option Groups' to the LADX player options page. * Moved 'Miscellaneous' group to the logic effecting groups.
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
…MW#3560) * Adding 'Option Groups' to the LADX player options page. * Moved 'Miscellaneous' group to the logic effecting groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adding the option groups to the options page for LADX.
This PR is a separated part of #3541 which was a duplicate of #3542. So this one is an addition of the already merged #3542.
How was this tested?
Starting the webhost locally and open the player options page. Also configuring and exporting configs, compare with a config from before the change and take a look if the result is the same.
If this makes graphical changes, please attach screenshots.