LADX: Changed option handling to @dataclass. #3541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
hatkirby
added
the
is: refactor/cleanup
NewSoupVi
reviewed
Jun 16, 2024
65 tasks
|
I've decided that we will go ahead with hatkirby's version of the option changes as they are a bit cleaner and fix more deprecated stuff After that, I'm happy to merge the option groups from this PR if you can rebuild them ontop of that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
LADX options didn't implemented dataclass so far. This leads to a lot of errors while generating a seed.
Additionally the player options page got grouped.
How was this tested?
Generated seeds with LADX players locally.
If this makes graphical changes, please attach screenshots.
LADX is not mentioned anymore in the warning at the beginning.
There are also no warnings anymore while generating a LADX seed which mentioned that getting options from multidata is deprecated.
The new options groups also changed the visuals on the player options page.
