-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: have webhost slot name links go through the launcher #2779
Core: have webhost slot name links go through the launcher #2779
Conversation
worth mentioning separate, but the reasoning for both |
with minor changes to my apworld (Minit):
i was able to successfully open my CommonClient extension in both passing the relevant url into commandline parameters (i.e. And can confirm that when my .apworld was not configured correctly and/or missing that it defaulted back to the text client as expected I also confirmed that the new links still open up the text client if the version of AP installed does not contain these updates |
# Conflicts: # WebHostLib/templates/macros.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had found some weird cases where a ghost launcher window launched on frozen builds, but after rebuilding clean on just this branch and just this branch sync'd with main confirmed that both options frozen did not have that, so it was likely some bad merge I had done when pulling in other PRs
# Conflicts: # Launcher.py # worlds/LauncherComponents.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been staring at this code a lot recently and came to a lot of the same conclusions. I think the popup could probably be expanded upon a bit in the future, but it's fine as is.
…ebhost_launch_clients
What is this fixing or adding?
Changes the slot name links on the website room pages to go through launcher instead of straight to common client. it then tries to find the matching valid component and will call that component if it can, falling back on common client with the uri as an arg.
How was this tested?
https://discord.com/channels/731205301247803413/731214280439103580/1201703250789929031
If this makes graphical changes, please attach screenshots.