CommonClient: abstract url handling so it's importable #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Exempt-Medic
added
the
is: enhancement
silasary
approved these changes
Oct 18, 2024
beauxq
reviewed
Oct 20, 2024
beauxq
reviewed
Oct 20, 2024
Co-authored-by: Doug Hoskisson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
abstracts out url handling so cc clients can import it easier when handling #2779
feel free to tell me a better way to type that btw lol
How was this tested?
ran
python launcher.py "Text Client" -- archipelago://test:@localhostand saw it auto fill and auto connectIf this makes graphical changes, please attach screenshots.