-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: test that item/location name groups are not empty #2748
Tests: test that item/location name groups are not empty #2748
Conversation
SoE fixed in #2747 KH2 failing for |
maybe not this PR but since we're adding a new module for groups probably want to move the existing tests to this module such as https://github.com/ArchipelagoMW/Archipelago/blob/main/test/general/test_items.py#L17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Makes sense, yeah. I'm waiting for KH2 before I do something that might conflict later. 😅 |
|
I put it on my TODO list. I think merging this now is better than delaying it. |
…MW#2748) * Tests: test that item/location name groups are not empty * Tests: better name for test_groups TestCase --------- Co-authored-by: Fabian Dill <[email protected]>
…MW#2748) * Tests: test that item/location name groups are not empty * Tests: better name for test_groups TestCase --------- Co-authored-by: Fabian Dill <[email protected]>
…MW#2748) * Tests: test that item/location name groups are not empty * Tests: better name for test_groups TestCase --------- Co-authored-by: Fabian Dill <[email protected]>
…MW#2748) * Tests: test that item/location name groups are not empty * Tests: better name for test_groups TestCase --------- Co-authored-by: Fabian Dill <[email protected]>
What is this fixing or adding?
Adds a test to see if any game defines empty item/location name groups, which is likely a bug.
How was this tested?
Unit tests.