Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: test that item/location name groups are not empty #2748

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

black-sliver
Copy link
Member

What is this fixing or adding?

Adds a test to see if any game defines empty item/location name groups, which is likely a bug.

How was this tested?

Unit tests.

@black-sliver
Copy link
Member Author

SoE fixed in #2747

KH2 failing for Location name group "Armored Xemnas" of "Kingdom Hearts 2" is empty @JaredWeakStrike

@alwaysintreble
Copy link
Collaborator

maybe not this PR but since we're adding a new module for groups probably want to move the existing tests to this module such as https://github.com/ArchipelagoMW/Archipelago/blob/main/test/general/test_items.py#L17

Copy link
Collaborator

@Jarno458 Jarno458 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarno458 Jarno458 added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jan 22, 2024
@black-sliver
Copy link
Member Author

maybe not this PR but since we're adding a new module for groups probably want to move the existing tests to this module such as https://github.com/ArchipelagoMW/Archipelago/blob/main/test/general/test_items.py#L17

Makes sense, yeah. I'm waiting for KH2 before I do something that might conflict later. 😅

@JaredWeakStrike
Copy link
Collaborator

maybe not this PR but since we're adding a new module for groups probably want to move the existing tests to this module such as https://github.com/ArchipelagoMW/Archipelago/blob/main/test/general/test_items.py#L17

Makes sense, yeah. I'm waiting for KH2 before I do something that might conflict later. 😅

#2757

@black-sliver
Copy link
Member Author

maybe not this PR but since we're adding a new module for groups probably want to move the existing tests to this module such as https://github.com/ArchipelagoMW/Archipelago/blob/main/test/general/test_items.py#L17

Makes sense, yeah. I'm waiting for KH2 before I do something that might conflict later. 😅

I put it on my TODO list. I think merging this now is better than delaying it.

@black-sliver black-sliver merged commit 5663c21 into ArchipelagoMW:main Jan 30, 2024
12 checks passed
@black-sliver black-sliver deleted the test-groups-not-empty branch January 30, 2024 07:34
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…MW#2748)

* Tests: test that item/location name groups are not empty

* Tests: better name for test_groups TestCase

---------

Co-authored-by: Fabian Dill <[email protected]>
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
…MW#2748)

* Tests: test that item/location name groups are not empty

* Tests: better name for test_groups TestCase

---------

Co-authored-by: Fabian Dill <[email protected]>
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
…MW#2748)

* Tests: test that item/location name groups are not empty

* Tests: better name for test_groups TestCase

---------

Co-authored-by: Fabian Dill <[email protected]>
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
…MW#2748)

* Tests: test that item/location name groups are not empty

* Tests: better name for test_groups TestCase

---------

Co-authored-by: Fabian Dill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants