Pokemon Emerald: Automatically exclude locations based on goal

[Zunawe]

What is this fixing or adding?

Automatically excludes the specific locations which aren't accessible until after the player's goal is completed.

Excluding locations rather than not creating the locations because I get the item pool from the location pool directly. Removing a location that carries a progression item in the vanilla game would mean I'd have to explicitly add that item back in later and remove a filler item. This is much cleaner, and barely makes a dent in the location count anyway.

It's technically still possible to further detect whether a player could reach post-champion locations without first defeating Norman, but it gets messy, and nobody's asking for that right now anyway. When you play for a Norman goal, you're probably expecting to reach your goal quickly and release without approaching anywhere near full completion.

This pretty much makes the Postgame Locations location group obsolete, but I'll leave it for now and consider removing it in a future update.

How was this tested?

Generating with the various triggering options and checking the spoiler log.

[NewSoupVi]

Extremely awesome feature, more games need this!

I have this as an option in Witness called "shuffle_postgame" and it is felt whenever I accidentally set it wrong, and an important progression item lands "behind !release".

I will say that I do prefer it being an option, because there are "no release" themed games, and for those you are expecting to keep playing after you win, so it's nice to be able to randomly required to do postgame content. But imo, "exclude postgame as an option that is on by default" > "always exclude postgame" >>>>>>>> "never exclude postgame", so this is markedly an improvement.

It looks correct from a programming perspective, don't know enough about Pokemon Emerald to say whether it's right logically, but the comments & code do seemingly match up.