Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon Emerald: Un-exclude locations that must contain progression #2840

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

Zunawe
Copy link
Collaborator

@Zunawe Zunawe commented Feb 17, 2024

What is this fixing or adding?

Caused/revealed by #2655 and found in the recent beta test. If one or more of the badge/hm locations is excluded, when Emerald's pre_fill tries to place shuffled badges or HMs onto those locations, it ignores them, doesn't place every badge/hm, and causes a lot of locations/items to become inaccessible. I thought setting allow_excluded=True would protect against this, but I think I misunderstood what it does.

This will prevent those locations from being excluded just before trying to give them to fill_restrictive, which will catch both the automatic exclusion of a couple post-goal locations in Petalburg and the manual exclusion by players.

The same problem seems to appear if you exclude a location that Emerald converts to unrandomized event locations, like badges or key items like bikes.

How was this tested?

Generated a few seeds before and after the change with either norman goal and shuffle badges or manually excluding a badge location with shuffle badges. Also for vanilla badges with a badge location manually excluded. Seeds that fail without the change don't fail with the change.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 17, 2024
@ScipioWright ScipioWright added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Feb 18, 2024
@Berserker66 Berserker66 merged commit 818b0a4 into ArchipelagoMW:main Feb 18, 2024
15 checks passed
@github-actions github-actions bot removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 18, 2024
@Zunawe Zunawe deleted the emerald-unexclude branch March 25, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants