-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Update typography system and values, implement compact theme #803
Conversation
# Conflicts: # packages/css/src/footer/footer.scss
I think it totally depends on whether we realistically expect there to be more density variants in the future, which is hard to guess. I'm not a huge fan of adding even more complexity to our already complex spacing system, so maybe we should go for a boolean to make it harder to make it more complex in the future ;) Unless we have an indication that more density variants are required? |
To be honest, a third density variation appears far-fetched. Extra compact? Semi-spacious?
Yes, how can no-one ever prevent unavoiding not disagreeing with that! I’ve replaced everything with |
Here are links to theming in Storybook: |
Thanks. The second and third link are about theming canvases, e.g. dark mode. The first is on theming Storybook itself. I can’t find anything on font sizes there yet. And I think that’s an important change we need. |
Text size 4 and 5 are the same now. If the designers agree, we’ll consolidate them in code in a separate PR.
The
.amsterdam-theme--density-high
class name is a very temporary approach to allow visually evaluating the updated font sizes. We will soon replace it with a theming layer.For the icon component, all ‘high density’ classes had to move to the bottom because of a specificity rule in Stylelint. For the rest, I minimised the changes to avoid merge conflicts. I did replace custom token names like
container-multiplier
withline-height
.