-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typography docs and Storybook theming #771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlnr
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation looks great with the TypeSet component, great find!
github-actions
bot
temporarily deployed
to
demo-typography-doc-blocks
November 20, 2023 23:08
Destroyed
github-actions
bot
temporarily deployed
to
demo-typography-doc-blocks
November 21, 2023 08:49
Destroyed
github-actions
bot
temporarily deployed
to
demo-typography-doc-blocks
November 21, 2023 09:01
Destroyed
dlnr
approved these changes
Nov 21, 2023
alimpens
reviewed
Nov 23, 2023
VincentSmedinga
commented
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VincentSmedinga
added a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This structures our typography documentation:
Typeset
doc block – with static font sizes or it will render longclamp
labelsIt also improves readability of our docs by enlarging the tiny prose text, applying our own font and increasing whitespace. There appears to be no better way to achieve this than to bluntly override CSS (see issues). Also
textSize
inthemeConfig
has no effect. Suggestions welcome, I do think we need the end result.