Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't keep file streams open #89

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Don't keep file streams open #89

merged 2 commits into from
Mar 1, 2024

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Feb 27, 2024

There have been reported issues with the new PATCH endpoint in localtest with error messages like

fail: Altinn.App.Api.Controllers.DataController[0]
      Unable to update data element 57abc10b-d54d-4fd8-bcee-79876d3feaee for instance 500000/8125c8ac-7624-44f3-8429-37ab780aa86c
      Altinn.App.Core.Helpers.PlatformHttpException: 500 - Internal Server Error - System.IO.IOException: The process cannot access the file '/AltinnPlatformLocal/blobs/krt/krt-1185a-1/8125c8ac-7624-44f3-8429-37ab780aa86c/data/57abc10b-d54d-4fd8-bcee-79876d3feaee' because it is being used by another process.

This is likely caused by not closing streams.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne ivarne requested review from acn-sbuad and tjololo February 27, 2024 14:56
@ivarne ivarne merged commit 189d19d into main Mar 1, 2024
1 check passed
@ivarne ivarne deleted the ivarne/closeFileStreams branch March 1, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants