Don't keep file streams open (#89)

Altinn · Mar 1, 2024 · 189d19d · 189d19d
1 parent 8ed54a8
commit 189d19d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Services/Storage/Implementation/DataRepository.cs b/src/Services/Storage/Implementation/DataRepository.cs
@@ -212,7 +212,7 @@ private string GetDataCollectionFolder()
 
         private static async Task<string> ReadFileAsString(string path)
         {
-            Stream stream = await ReadFileAsStream(path);
+            using Stream stream = await ReadFileAsStream(path);
             using StreamReader reader = new StreamReader(stream);
             return await reader.ReadToEndAsync();
         }

diff --git a/src/Services/Storage/Implementation/DataService.cs b/src/Services/Storage/Implementation/DataService.cs
@@ -42,7 +42,7 @@ public Task StartFileScan(Instance instance, DataType dataType, DataElement data
                 return (null, new ServiceError(404, $"DataElement not found, dataElementId: {dataElementId}"));
             }
 
-            Stream filestream = await _dataRepository.ReadDataFromStorage(org, dataElement.BlobStoragePath);
+            using Stream filestream = await _dataRepository.ReadDataFromStorage(org, dataElement.BlobStoragePath);
             if (filestream == null || !filestream.CanRead)
             {
                 return (null, new ServiceError(404, $"Failed reading file, dataElementId: {dataElementId}"));