Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/382 consistent timezone #389

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Chore/382 consistent timezone #389

merged 4 commits into from
Jan 9, 2024

Conversation

tjololo
Copy link
Member

@tjololo tjololo commented Dec 21, 2023 •
edited
Loading

Description

Fixes #382
Some other changes to DefaultEFormidlingService to make testing easier.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@tjololo tjololo linked an issue Dec 21, 2023 that may be closed by this pull request
Remove use of DateTime.Now in ValidationAppSI and DefaultEformidlingService #382
Closed
@tjololo tjololo requested review from RonnyB71 and ivarne January 2, 2024 07:26
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tjololo tjololo merged commit 45cfc6d into v8 Jan 9, 2024
9 checks passed
@tjololo tjololo deleted the chore/382-consistent-timezone branch January 9, 2024 07:24
@tjololo tjololo added the bugfix Label Pull requests with bugfix. Used when generation releasenotes label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorntore bjorntore bjorntore approved these changes

@ivarne ivarne ivarne approved these changes

@RonnyB71 RonnyB71 Awaiting requested review from RonnyB71

Assignees
No one assigned
Labels
bugfix Label Pull requests with bugfix. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of DateTime.Now in ValidationAppSI and DefaultEformidlingService
3 participants
@tjololo @ivarne @bjorntore