Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of DateTime.Now in ValidationAppSI and DefaultEformidlingService #382

Closed
tjololo opened this issue Dec 19, 2023 · 0 comments · Fixed by #389
Closed

Remove use of DateTime.Now in ValidationAppSI and DefaultEformidlingService #382

tjololo opened this issue Dec 19, 2023 · 0 comments · Fixed by #389
Assignees

Comments

@tjololo
Copy link
Member

tjololo commented Dec 19, 2023

Description of the bug

In all other places where we need to get the current time we use DateTime.UtcNow. In ValidationAppSI and DefaultEFormidlingService we use DateTIme.Now. I the correct way is to use UtcNow as that will remove the connection to the timesone where the code is executed.
If UtcNow is wrong we at least need to be consistent across our codebase

Steps To Reproduce

  1. Create an app submit a for
  2. See Timestampe in the instance validated block. This has timezone matching the computers timezone
  3. Other timestamps are in utc

Additional Information

No response

@tjololo tjololo added kind/bug Something isn't working status/triage labels Dec 19, 2023
@tjololo tjololo moved this to 👷 In Progress in Team Apps Dec 20, 2023
@tjololo tjololo self-assigned this Dec 20, 2023
@tjololo tjololo added kind/chore and removed status/triage kind/bug Something isn't working labels Dec 20, 2023
@tjololo tjololo linked a pull request Dec 21, 2023 that will close this issue
5 tasks
@tjololo tjololo moved this from 👷 In Progress to 🔎 Review in Team Apps Dec 21, 2023
@tjololo tjololo changed the title Use of DateTime.Now in ValidationAppSI and DefaultEformidlingService Remove use of DateTime.Now in ValidationAppSI and DefaultEformidlingService Jan 2, 2024
@tjololo tjololo moved this from 🔎 Review to 🧪 Test in Team Apps Jan 9, 2024
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ✅ Done in Team Apps Jan 10, 2024
@ivarne ivarne closed this as completed Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants