Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backend endpoints for instance creation and dataelement operations #14154

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Nov 25, 2024

Description

  • Refactored preview instances to be mocked closer to how app-lib-core handles instances.
  • Restructured controllers on the backend to more closely resemble app-lib-core structure. This should make it easier to reference app-lib-core when editing/updating the mock in the future.
  • Moved preview support for V3 apps to separate controllers in a new folder to separate the legacy code. This should make maintenance/refactoring a bit easier.

This change allows the preview to use multiple datamodels without mocking every datamodel explicitly.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Nov 25, 2024
@Jondyr Jondyr force-pushed the 11-25-backend_endpoints_for_instance_creation_and_dataelement_operations branch 2 times, most recently from 9abbeb6 to 82af7d3 Compare November 26, 2024 12:53
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Nov 26, 2024
@Jondyr Jondyr force-pushed the 11-25-backend_endpoints_for_instance_creation_and_dataelement_operations branch from 82af7d3 to 6772565 Compare November 26, 2024 14:05
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend labels Nov 26, 2024
@Jondyr Jondyr force-pushed the 11-25-backend_endpoints_for_instance_creation_and_dataelement_operations branch 7 times, most recently from f69815b to a15e3c7 Compare December 2, 2024 08:19
@Jondyr Jondyr force-pushed the 11-25-backend_endpoints_for_instance_creation_and_dataelement_operations branch from 5b7a457 to a5fba66 Compare December 2, 2024 10:11
@Jondyr Jondyr linked an issue Dec 5, 2024 that may be closed by this pull request
@Jondyr Jondyr force-pushed the 11-25-backend_endpoints_for_instance_creation_and_dataelement_operations branch from 88aeb1c to 53a264d Compare December 5, 2024 10:41
@Jondyr Jondyr force-pushed the 11-25-backend_endpoints_for_instance_creation_and_dataelement_operations branch 3 times, most recently from 06e6c48 to 6670019 Compare December 9, 2024 05:53
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.53%. Comparing base (9f43969) to head (155a940).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kages/ux-editor/src/components/Preview/Preview.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14154   +/-   ##
=======================================
  Coverage   95.52%   95.53%           
=======================================
  Files        1817     1815    -2     
  Lines       23700    23694    -6     
  Branches     2749     2752    +3     
=======================================
- Hits        22640    22636    -4     
+ Misses        807      805    -2     
  Partials      253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr marked this pull request as ready for review December 9, 2024 09:31
@Jondyr Jondyr force-pushed the 11-25-backend_endpoints_for_instance_creation_and_dataelement_operations branch from 806c530 to 57f6cba Compare December 9, 2024 09:31
@Jondyr Jondyr force-pushed the 11-25-backend_endpoints_for_instance_creation_and_dataelement_operations branch from 57f6cba to 155a940 Compare December 9, 2024 11:35
@lassopicasso
Copy link
Contributor

When this is merged, move #13797 from blocked to test. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. backend frontend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview Fails When Linking Component to Non-Default Data Model
2 participants