Fix preview test

s
Altinn · Dec 5, 2024 · 53a264d · 53a264d
1 parent b3d7e4e
commit 53a264d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/frontend/packages/ux-editor/src/components/Preview/Preview.test.tsx b/frontend/packages/ux-editor/src/components/Preview/Preview.test.tsx
@@ -84,7 +84,7 @@ describe('Preview', () => {
   });
 
   it('reloads preview when the selected form layout name changes', async () => {
-    const view = render();
+    render();
     expect(appContextMock.previewIframeRef?.current?.src).toBe(
       'http://localhost' +
         previewPage(
@@ -99,9 +99,8 @@ describe('Preview', () => {
     const newSelectedFormLayoutName = 'test';
     appContextMock.selectedFormLayoutName = newSelectedFormLayoutName;
 
-    view.rerender(<Preview collapsed={false} onCollapseToggle={jest.fn()} />);
-
-    expect(appContextMock.previewIframeRef?.current?.src).toBe(
+    render();
+    expect(appContextMock.previewIframeRef.current.src).toBe(
       'http://localhost' +
         previewPage(
           org,

diff --git a/frontend/packages/ux-editor/src/components/Preview/Preview.tsx b/frontend/packages/ux-editor/src/components/Preview/Preview.tsx
@@ -95,6 +95,7 @@ const PreviewFrame = () => {
     mutate: createInstance,
     data: instance,
     isError: createInstanceError,
+    isPending: createInstancePending,
   } = useCreatePreviewInstanceMutation(org, app);
 
   useEffect(() => {
@@ -107,7 +108,7 @@ const PreviewFrame = () => {
     };
   }, [previewIframeRef]);
 
-  if (!instance) {
+  if (createInstancePending) {
     return (
       <StudioCenter>
         {createInstanceError ? (
@@ -118,6 +119,14 @@ const PreviewFrame = () => {
       </StudioCenter>
     );
   }
+  const previewURL = previewPage(
+    org,
+    app,
+    selectedFormLayoutSetName,
+    taskId,
+    selectedFormLayoutName,
+    instance?.id,
+  );
 
   return (
     <div className={classes.root}>
@@ -129,14 +138,7 @@ const PreviewFrame = () => {
             ref={previewIframeRef}
             className={cn(classes.iframe, classes[viewportToSimulate])}
             title={t('ux_editor.preview')}
-            src={previewPage(
-              org,
-              app,
-              selectedFormLayoutSetName,
-              taskId,
-              selectedFormLayoutName,
-              instance?.id,
-            )}
+            src={previewURL}
             onLoad={previewHasLoaded}
           />
         </div>