Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix and suffix text for Input and add alertOnChange for multiselect and dropdown #13106

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

standeren
Copy link
Contributor

Description

Run script that updated texts for Input and new properties alertOnChange for MultiSelect and Dropdown.

  • Add texts in nb.json for the new texts in InputSchema
  • AlertOnChange was already supported out of the box 🫡

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jul 6, 2024
@standeren standeren linked an issue Jul 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (788c6fd) to head (ac0181f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13106   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files        1426     1426           
  Lines       19958    19958           
  Branches     2389     2389           
=======================================
  Hits        18339    18339           
  Misses       1360     1360           
  Partials      259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErlingHauan ErlingHauan self-requested a review July 9, 2024 05:58
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix and Suffix now appears on the Input component, and AlertOnChange is now visible on both Input and MultipleSelect 👌

I noticed that we get some text overflow when clicking on "Prefix" or "Suffix", before entering a prefix or suffix. Is this something we can fix, or is it for team Apps to do?
image

Also noticed that we no longer can choose a currency - see the other comment below.

Nice work 😊

@standeren
Copy link
Contributor Author

Prefix and Suffix now appears on the Input component, and AlertOnChange is now visible on both Input and MultipleSelect 👌

I noticed that we get some text overflow when clicking on "Prefix" or "Suffix", before entering a prefix or suffix. Is this something we can fix, or is it for team Apps to do? image

Also noticed that we no longer can choose a currency - see the other comment below.

Nice work 😊

Thanks 🥳
The overflow is not possible for us to fix in an easy way. But in a different PR of mine I ensure that empty added texts are removed from the component. In that way we will not get an empty text-key in this case. Then the prefix and suffix will only be visible in preview if an actual text is connected to them! 😄

But nice catch 😉

Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 😄

@standeren standeren merged commit 441dc05 into main Jul 11, 2024
11 checks passed
@standeren standeren deleted the add-prefix-and-suffix-texts-for-input branch July 11, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prefix and suffix text resource binding for input component
2 participants